Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 2623703002: Removes WmRootWindowController::GetShell() (Closed)

Created:
3 years, 11 months ago by sky
Modified:
3 years, 11 months ago
Reviewers:
msw
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removes WmRootWindowController::GetShell() Was never used, and WmShell::Get() can be used instead. BUG=671246 TEST=none R=msw@chromium.org Review-Url: https://codereview.chromium.org/2623703002 Cr-Commit-Position: refs/heads/master@{#442495} Committed: https://chromium.googlesource.com/chromium/src/+/7c2fc9f366ac5481f00369bcbbff17bed9da98e0

Patch Set 1 #

Patch Set 2 : merge #

Patch Set 3 : not relative #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -14 lines) Patch
M ash/aura/wm_root_window_controller_aura.h View 1 chunk +0 lines, -1 line 0 comments Download
M ash/aura/wm_root_window_controller_aura.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M ash/common/wm_root_window_controller.h View 2 chunks +0 lines, -3 lines 0 comments Download
M ash/mus/bridge/wm_root_window_controller_mus.h View 1 chunk +0 lines, -1 line 0 comments Download
M ash/mus/bridge/wm_root_window_controller_mus.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
sky
3 years, 11 months ago (2017-01-09 22:55:58 UTC) #1
msw
lgtm
3 years, 11 months ago (2017-01-09 23:27:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2623703002/20001
3 years, 11 months ago (2017-01-10 03:26:52 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2623703002/30001
3 years, 11 months ago (2017-01-10 03:27:22 UTC) #8
commit-bot: I haz the power
3 years, 11 months ago (2017-01-10 05:23:14 UTC) #11
Message was sent while issue was closed.
Committed patchset #3 (id:30001) as
https://chromium.googlesource.com/chromium/src/+/7c2fc9f366ac5481f00369bcbbff...

Powered by Google App Engine
This is Rietveld 408576698