Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 2624553002: Move nav timing 2's wpt tests into w3c/webperf/approved directory (Closed)

Created:
3 years, 11 months ago by sunjian
Modified:
3 years, 11 months ago
Reviewers:
panicker
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move nav timing 2's wpt tests into w3c/webperf/approved directory BUG=80267 Review-Url: https://codereview.chromium.org/2624553002 Cr-Commit-Position: refs/heads/master@{#443084} Committed: https://chromium.googlesource.com/chromium/src/+/760800d72f2e61cefab8d9fca7cb36fa29867a80

Patch Set 1 #

Patch Set 2 : made path changes to the tests #

Patch Set 3 : added two more tests #

Patch Set 4 : got rid of non-test file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1177 lines, -0 lines) Patch
A third_party/WebKit/LayoutTests/http/tests/w3c/webperf/approved/navigation-timing/html/nav2_idlharness.html View 1 2 1 chunk +69 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/w3c/webperf/approved/navigation-timing/html/nav2_idlharness-expected.txt View 1 2 1 chunk +18 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/w3c/webperf/approved/navigation-timing/html/nav2_test_attributes_exist.html View 1 chunk +66 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/w3c/webperf/approved/navigation-timing/html/nav2_test_attributes_values.html View 1 1 chunk +98 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/w3c/webperf/approved/navigation-timing/html/nav2_test_document_open.html View 1 1 chunk +100 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/w3c/webperf/approved/navigation-timing/html/nav2_test_instance_accessors.html View 1 chunk +74 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/w3c/webperf/approved/navigation-timing/html/nav2_test_navigate_within_document.html View 1 chunk +83 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/w3c/webperf/approved/navigation-timing/html/nav2_test_navigation_type_backforward.html View 1 1 chunk +81 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/w3c/webperf/approved/navigation-timing/html/nav2_test_navigation_type_navigate.html View 1 chunk +32 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/w3c/webperf/approved/navigation-timing/html/nav2_test_navigation_type_reload.html View 1 1 chunk +53 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/w3c/webperf/approved/navigation-timing/html/nav2_test_open_blank_page.html View 1 chunk +28 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/w3c/webperf/approved/navigation-timing/html/nav2_test_open_data_uri.html View 1 2 1 chunk +30 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/w3c/webperf/approved/navigation-timing/html/nav2_test_redirect_none.html View 1 chunk +33 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/w3c/webperf/approved/navigation-timing/html/nav2_test_redirect_server.html View 1 1 chunk +46 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/w3c/webperf/approved/navigation-timing/html/nav2_test_redirect_xserver.html View 1 1 chunk +48 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/w3c/webperf/approved/navigation-timing/html/nav2_test_redirect_xserver_opt_in.html View 1 1 chunk +56 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/w3c/webperf/approved/navigation-timing/html/nav2_test_unique_nav_instances.html View 1 chunk +76 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/w3c/webperf/approved/navigation-timing/html/nav2_test_unloadEvents_no_previous_document.html View 1 1 chunk +36 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/w3c/webperf/approved/navigation-timing/html/nav2_test_unloadEvents_previous_document_cross_origin.html View 1 1 chunk +44 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/w3c/webperf/approved/navigation-timing/html/nav2_test_unloadEvents_with_cross_origin_redirects.html View 1 1 chunk +55 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/w3c/webperf/approved/navigation-timing/html/nav2_test_unloadEvents_with_previous_document.html View 1 1 chunk +42 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/w3c/webperf/resources/redirect-opt-in.php View 1 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (13 generated)
sunjian
All the tests got added to wpt on github have their corresponding copy in this ...
3 years, 11 months ago (2017-01-11 19:24:52 UTC) #5
panicker
LGTM
3 years, 11 months ago (2017-01-11 21:45:05 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2624553002/60001
3 years, 11 months ago (2017-01-11 23:13:31 UTC) #14
commit-bot: I haz the power
3 years, 11 months ago (2017-01-12 00:37:56 UTC) #17
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/760800d72f2e61cefab8d9fca7cb...

Powered by Google App Engine
This is Rietveld 408576698