Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(489)

Issue 2624543003: Increase kSyncOperationTimeout to let SyncFakeServerTest pass on slow lab machines (Closed)

Created:
3 years, 11 months ago by pavely
Modified:
3 years, 11 months ago
Reviewers:
bzanotti
CC:
chromium-reviews, pkl (ping after 24h if needed), noyau+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Increase kSyncOperationTimeout to let SyncFakeServerTest pass on slow lab machines testSyncTypedURLDeleteFromServer test failed with timeout waiting for FakeServer to receive updates. I'm trying to verify if it happened because of the slow hardware in the lab. To do so I'm increasing kSyncOperationTimeout to 10 seconds. BUG=672286 R=bzanotti@chromium.org Review-Url: https://codereview.chromium.org/2624543003 Cr-Commit-Position: refs/heads/master@{#442633} Committed: https://chromium.googlesource.com/chromium/src/+/61da5ae4dc99bc1812d1613d83865c082f1598ba

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ios/chrome/browser/ui/sync/sync_fake_server_egtest.mm View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 11 (7 generated)
pavely
3 years, 11 months ago (2017-01-09 20:44:21 UTC) #3
bzanotti
LGTM
3 years, 11 months ago (2017-01-10 09:46:30 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2624543003/1
3 years, 11 months ago (2017-01-10 18:16:31 UTC) #8
commit-bot: I haz the power
3 years, 11 months ago (2017-01-10 18:20:53 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/61da5ae4dc99bc1812d1613d8386...

Powered by Google App Engine
This is Rietveld 408576698