Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Issue 2624543002: Update assertion in finalizer (Closed)

Created:
3 years, 11 months ago by hausner
Modified:
3 years, 11 months ago
Reviewers:
regis
CC:
reviews_dartlang.org, vm-dev_dartlang.org, Kevin Millikin (Google)
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Update assertion in finalizer Kernel IR omits the implicit constructor when it is not needed, e.g. in abstract classes. Update assertion in finalizer. BUG= R=regis@google.com Committed: https://github.com/dart-lang/sdk/commit/47a479741f07a4b05f878b220779906c45e70e21

Patch Set 1 #

Patch Set 2 : Keep the assertion, actually #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M runtime/vm/class_finalizer.cc View 1 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
hausner
3 years, 11 months ago (2017-01-09 20:16:09 UTC) #3
hausner
As discussed offline, the assertion is still useful, so I added an exception to accommodate ...
3 years, 11 months ago (2017-01-09 21:16:35 UTC) #5
regis
lgtm
3 years, 11 months ago (2017-01-09 21:19:02 UTC) #6
hausner
3 years, 11 months ago (2017-01-09 21:29:36 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
47a479741f07a4b05f878b220779906c45e70e21 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698