Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Unified Diff: runtime/vm/class_finalizer.cc

Issue 2624543002: Update assertion in finalizer (Closed)
Patch Set: Keep the assertion, actually Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/class_finalizer.cc
diff --git a/runtime/vm/class_finalizer.cc b/runtime/vm/class_finalizer.cc
index f2396612d13b5928bc9e164dd0fd595aa8e16d0f..be24a412b4e6cedd580541084fa323ae30e6ec64 100644
--- a/runtime/vm/class_finalizer.cc
+++ b/runtime/vm/class_finalizer.cc
@@ -2518,8 +2518,9 @@ void ClassFinalizer::FinalizeClass(const Class& cls) {
cls.SetFunctions(functions);
}
// Every class should have at least a constructor, unless it is a top level
- // class or a typedef class.
- ASSERT(cls.IsTopLevel() || cls.IsTypedefClass() ||
+ // class or a typedef class. The Kernel frontend does not create an implicit
+ // constructor for abstract classes.
+ ASSERT(cls.IsTopLevel() || cls.IsTypedefClass() || cls.is_abstract() ||
(Array::Handle(cls.functions()).Length() > 0));
// Resolve and finalize all member types.
ResolveAndFinalizeMemberTypes(cls);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698