Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 2624443004: Revert of Enabling kUseConsolidatedStartupFlow by default on trunk. (Closed)

Created:
3 years, 11 months ago by foolip
Modified:
3 years, 11 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Enabling kUseConsolidatedStartupFlow by default on trunk. (patchset #23 id:440001 of https://codereview.chromium.org/2475913003/ ) Reason for revert: StartupBrowserCreatorFirstRunTest.RestoreOnStartupURLsPolicySpecified failing on Win10 Tests x64 BUG=679671 Original issue's description: > Enabling kUseConsolidatedStartupFlow by default on trunk. > > Code changes: > - Disabling onboarding content for ChromeOS. Promotions for CrOS are out-of-scope for this launch. > - Ensuring that preference-specified tabs do not appear in new windows when a tabbed browser already exists for the profile. > > Test changes: > - Removed 12 outdated tests > - Fixed or updated 9 tests > > Details of affected tests, and rationale, can be found in this doc: https://docs.google.com/a/google.com/document/d/1PjAemEEFrl0gIDVQfnr1oAnHkb6DcV47HlOyyo7ICZI/edit?usp=sharing > > BUG=608875, 314819, 313856 > > Review-Url: https://codereview.chromium.org/2475913003 > Cr-Commit-Position: refs/heads/master@{#442487} > Committed: https://chromium.googlesource.com/chromium/src/+/a52322134679a349366417e04e502bc8ce1f68e4 TBR=pkasting@chromium.org,rsesek@chromium.org,tmartino@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=608875, 314819, 313856 Review-Url: https://codereview.chromium.org/2624443004 Cr-Commit-Position: refs/heads/master@{#442544} Committed: https://chromium.googlesource.com/chromium/src/+/d38026c5a4b7a69552a4d7f41c37fdb735f0e283

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+567 lines, -122 lines) Patch
M chrome/browser/app_controller_mac_browsertest.mm View 4 chunks +5 lines, -15 lines 0 comments Download
M chrome/browser/ui/startup/startup_browser_creator_browsertest.cc View 10 chunks +538 lines, -35 lines 0 comments Download
M chrome/browser/ui/startup/startup_browser_creator_triggered_reset_browsertest_win.cc View 4 chunks +10 lines, -23 lines 0 comments Download
M chrome/browser/ui/startup/startup_features.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/startup/startup_tab_provider.h View 1 chunk +4 lines, -6 lines 0 comments Download
M chrome/browser/ui/startup/startup_tab_provider.cc View 5 chunks +5 lines, -27 lines 0 comments Download
M chrome/browser/ui/startup/startup_tab_provider_unittest.cc View 1 chunk +4 lines, -15 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
foolip
Created Revert of Enabling kUseConsolidatedStartupFlow by default on trunk.
3 years, 11 months ago (2017-01-10 10:00:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2624443004/1
3 years, 11 months ago (2017-01-10 10:01:12 UTC) #3
commit-bot: I haz the power
3 years, 11 months ago (2017-01-10 10:02:45 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d38026c5a4b7a69552a4d7f41c37...

Powered by Google App Engine
This is Rietveld 408576698