Enable ThreadRestrictionVerifier for StringImpl

third_party/WebKit/Source/core/dom/Node.cpp

Index: third_party/WebKit/Source/core/dom/Node.cpp
diff --git a/third_party/WebKit/Source/core/dom/Node.cpp b/third_party/WebKit/Source/core/dom/Node.cpp
index caf5618827c3424f3f6e8939958d3761287ee1f4..d4ea352e03160eab39cd439168660ebcad34c3ef 100644
--- a/third_party/WebKit/Source/core/dom/Node.cpp
+++ b/third_party/WebKit/Source/core/dom/Node.cpp
@@ -1493,7 +1493,15 @@ String Node::debugName() const {
     const Element& thisElement = toElement(*this);
     if (thisElement.hasID()) {
       name.append(" id=\'");
-      name.append(thisElement.getIdAttribute());
+      // Unsafe hack to avoid triggering the ThreadRestrictionVerifier on
+      // StringImpl. crbug.com/545926 should be fixed completely, and we should
+      // always avoid accessing these strings from the impl thread.
+      StringImpl* impl = thisElement.getIdAttribute().impl();
+      if (impl) {
+        name.append(impl->is8Bit()

[esprehn, 2017/01/11 22:34:01]

Why does't the thisElement.classNames() line below cause the same assert? How
can we change this line to be like those lines?

Also how is the impl thread calling debugName() like this? It's touching the DOM
from a background thread, that sounds like crash city. :(

+                        ? StringView(impl->characters8(), impl->length())
+                        : StringView(impl->characters16(), impl->length()));
+      }
       name.append('\'');
     }