Enable ThreadRestrictionVerifier for StringImpl

third_party/WebKit/Source/core/dom/Node.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2001 Dirk Mueller (mueller@kde.org)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All
  * rights reserved.
  * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)
  * Copyright (C) 2009 Torch Mobile Inc. All rights reserved.
  * (http://www.torchmobile.com/)
  *
@@ skipping 1475 matching lines @@
                    connection;
 }
 
 String Node::debugName() const {
   StringBuilder name;
   name.append(debugNodeName());
   if (isElementNode()) {
     const Element& thisElement = toElement(*this);
     if (thisElement.hasID()) {
       name.append(" id=\'");
-      name.append(thisElement.getIdAttribute());
+      // Unsafe hack to avoid triggering the ThreadRestrictionVerifier on
+      // StringImpl. crbug.com/545926 should be fixed completely, and we should
+      // always avoid accessing these strings from the impl thread.
+      StringImpl* impl = thisElement.getIdAttribute().impl();
+      if (impl) {
+        name.append(impl->is8Bit()

[esprehn, 2017/01/11 22:34:01]

Why does't the thisElement.classNames() line below cause the same assert? How
can we change this line to be like those lines?

Also how is the impl thread calling debugName() like this? It's touching the DOM
from a background thread, that sounds like crash city. :(

+                        ? StringView(impl->characters8(), impl->length())
+                        : StringView(impl->characters16(), impl->length()));
+      }
       name.append('\'');
     }
 
     if (thisElement.hasClass()) {
       name.append(" class=\'");
       for (size_t i = 0; i < thisElement.classNames().size(); ++i) {
         if (i > 0)
           name.append(' ');
         name.append(thisElement.classNames()[i]);
       }
@@ skipping 1035 matching lines @@
   if (node) {
     std::stringstream stream;
     node->printNodePathTo(stream);
     LOG(INFO) << stream.str();
   } else {
     LOG(INFO) << "Cannot showNodePath for <null>";
   }
 }
 
 #endif