DevTools: avoid race condition between ExecutionContextSelector.js and Main.js

DevTools: avoid race condition between ExecutionContextSelector.js and Main.js

This originated from my CL to extract files from modules:
crrev.com/442706

Main sometimes calls _createAppUI which instantiates ExecutionContextSelector 
before ExecutionContextSelector.js is loaded.

I also made runOnWindowLoad async to be consistently async 

BUG=none

Review-Url: https://codereview.chromium.org/2624383005
Cr-Commit-Position: refs/heads/master@{#443494}
Committed: https://chromium.googlesource.com/chromium/src/+/86937b7b7c70e5e024edabf19d60b3ae1e7d247c

[chenwilliam, 2017-01-13 00:56:36]

Description was changed from

==========
DevTools: avoid race condition between ExecutionContextSelector.js and Main.js

This originated from my CL to extract files from modules:
crrev.com/442706

Main sometimes calls _createAppUI before ExecutionContextSelector.js is loaded.

BUG=none
==========

to

==========
DevTools: avoid race condition between ExecutionContextSelector.js and Main.js

This originated from my CL to extract files from modules:
crrev.com/442706

Main sometimes calls _createAppUI which instantiates ExecutionContextSelector 
before ExecutionContextSelector.js is loaded.

BUG=none
==========

[chenwilliam, 2017-01-13 00:56:36]

chenwilliam@chromium.org changed reviewers:
+ dgozman@chromium.org

[chenwilliam, 2017-01-13 00:57:35]

PTAL

[pfeldman, 2017-01-13 00:59:47]

On 2017/01/13 00:57:35, chenwilliam wrote:
> PTAL

It might be a better idea to use setImmediate(callback) in runOnWindowLoad. That
way we are consistently async.

[chenwilliam, 2017-01-13 01:30:45]

Description was changed from

==========
DevTools: avoid race condition between ExecutionContextSelector.js and Main.js

This originated from my CL to extract files from modules:
crrev.com/442706

Main sometimes calls _createAppUI which instantiates ExecutionContextSelector 
before ExecutionContextSelector.js is loaded.

BUG=none
==========

to

==========
DevTools: avoid race condition between ExecutionContextSelector.js and Main.js

This originated from my CL to extract files from modules:
crrev.com/442706

Main sometimes calls _createAppUI which instantiates ExecutionContextSelector 
before ExecutionContextSelector.js is loaded.

I also made runOnWindowLoad async to be consistently async 

BUG=none
==========

[chenwilliam, 2017-01-13 01:31:12]

chenwilliam@chromium.org changed reviewers:
+ pfeldman@chromium.org

[chenwilliam, 2017-01-13 01:31:12]

PTAL. I added the setImmediate. There's still a race condition in dev mode with
loading ExecutionContextSelector.js, so I've kept the re-ordering.

[chenwilliam, 2017-01-13 01:40:01]

Patchset #2 (id:20001) has been deleted

[pfeldman, 2017-01-13 01:51:09]

ps#1 lgtm

[chenwilliam, 2017-01-13 01:53:46]

The CQ bit was checked by chenwilliam@chromium.org

[chenwilliam, 2017-01-13 01:53:47]

The CQ bit was unchecked by chenwilliam@chromium.org

[chenwilliam, 2017-01-13 01:53:47]

The CQ bit was checked by chenwilliam@chromium.org

[commit-bot: I haz the power, 2017-01-13 01:54:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-13 04:59:27]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1484272427747120, "parent_rev":
"6758be03e71c7423fb1b43dc267049ebc4ceaf27", "commit_rev":
"86937b7b7c70e5e024edabf19d60b3ae1e7d247c"}

[commit-bot: I haz the power, 2017-01-13 04:59:58]

Description was changed from

==========
DevTools: avoid race condition between ExecutionContextSelector.js and Main.js

This originated from my CL to extract files from modules:
crrev.com/442706

Main sometimes calls _createAppUI which instantiates ExecutionContextSelector 
before ExecutionContextSelector.js is loaded.

I also made runOnWindowLoad async to be consistently async 

BUG=none
==========

to

==========
DevTools: avoid race condition between ExecutionContextSelector.js and Main.js

This originated from my CL to extract files from modules:
crrev.com/442706

Main sometimes calls _createAppUI which instantiates ExecutionContextSelector 
before ExecutionContextSelector.js is loaded.

I also made runOnWindowLoad async to be consistently async 

BUG=none

Review-Url: https://codereview.chromium.org/2624383005
Cr-Commit-Position: refs/heads/master@{#443494}
Committed:
https://chromium.googlesource.com/chromium/src/+/86937b7b7c70e5e024edabf19d60...
==========

[commit-bot: I haz the power, 2017-01-13 04:59:59]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/86937b7b7c70e5e024edabf19d60...