cros: Lock Screen: Fixed an issue with tab order on the lock screen.

cros: Lock Screen: Fixed an issue with tab order on the lock screen.

The tabbing on the lock screen used to hit the header bar before the pin keyboard. After this change the pin keyboard gets tabbed to with a caveat. The root gets a focus before the buttons, thus having a extra step. I have a solution but it is really hacky. I think having to press the tab key one extra time is still better than having tab reach the header bar first. What do you guys think?

BUG=680634
TEST=NONE
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2624383004
Cr-Commit-Position: refs/heads/master@{#444822}
Committed: https://chromium.googlesource.com/chromium/src/+/d0c3035247b102beb3b9121e58c65c650c2d2916

[sammiequon, 2017-01-12 20:00:13]

Description was changed from

==========
cros: Lock Screen: Fixed an issue with tab order on the lock screen.

The tabbing on the lock screen used to hit the header bar before the pin
keyboard. After this change the pin keyboard gets tabbed to with a caveat. The
root gets a focus before the buttons, thus having a extra step. I have a
solution but it is really hacky. I think having to press the tab key one extra
time is still better than having tab reach the header bar first. What do you
guys think?

BUG=680634
TEST=NONE
==========

to

==========
cros: Lock Screen: Fixed an issue with tab order on the lock screen.

The tabbing on the lock screen used to hit the header bar before the pin
keyboard. After this change the pin keyboard gets tabbed to with a caveat. The
root gets a focus before the buttons, thus having a extra step. I have a
solution but it is really hacky. I think having to press the tab key one extra
time is still better than having tab reach the header bar first. What do you
guys think?

BUG=680634
TEST=NONE
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[sammiequon, 2017-01-12 20:02:46]

sammiequon@chromium.org changed reviewers:
+ jdufault@chromium.org, xiyuan@chromium.org

[sammiequon, 2017-01-12 20:02:46]

jdufault@, xiyuan@ - Please take a look. Thanks!

[jdufault, 2017-01-12 20:42:56]

On 2017/01/12 20:02:46, sammiequon wrote:
> jdufault@, xiyuan@ - Please take a look. Thanks!

What's the behavior when the PIN keyboard is disabled and there is only a
password input box? PIN should be the same. iirc, you use arrow keys to access
the actual number elements on the PIN keyboard (or at least I believe that is
the desired behavior).

[jdufault, 2017-01-12 20:43:03]

https://codereview.chromium.org/2624383004/diff/1/ui/login/account_picker/use...
File ui/login/account_picker/user_pod_row.js (right):

https://codereview.chromium.org/2624383004/diff/1/ui/login/account_picker/use...
ui/login/account_picker/user_pod_row.js:93: // button newxt to password input
field and the pod
newxt => next

[jdufault, 2017-01-12 20:43:37]

https://codereview.chromium.org/2624383004/diff/1/chrome/browser/resources/ch...
File chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.html (right):

https://codereview.chromium.org/2624383004/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.html:36: outline:
none;
Unrelated change?

[sammiequon, 2017-01-12 21:22:31]

On 2017/01/12 20:42:56, jdufault wrote:
> On 2017/01/12 20:02:46, sammiequon wrote:
> > jdufault@, xiyuan@ - Please take a look. Thanks!
> 
> What's the behavior when the PIN keyboard is disabled and there is only a
> password input box? PIN should be the same. iirc, you use arrow keys to access
> the actual number elements on the PIN keyboard (or at least I believe that is
> the desired behavior).

When the PIN keyboard is disabled tabbing takes focus from the pod to the header
bar. With the PIN keyboard tabbing takes focus to the pod to the header bar back
to the pin keyboard and back to the header bar. The arrow keys do not do
anything on the pin keyboard.

[sammiequon, 2017-01-17 20:00:57]

https://codereview.chromium.org/2624383004/diff/1/chrome/browser/resources/ch...
File chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.html (right):

https://codereview.chromium.org/2624383004/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.html:36: outline:
none;
On 2017/01/12 20:43:37, jdufault wrote:
> Unrelated change?

Because the CL causes the host to receive focus on tab, whenever the host
receives focus it shows a blue outline.

https://codereview.chromium.org/2624383004/diff/1/ui/login/account_picker/use...
File ui/login/account_picker/user_pod_row.js (right):

https://codereview.chromium.org/2624383004/diff/1/ui/login/account_picker/use...
ui/login/account_picker/user_pod_row.js:93: // button newxt to password input
field and the pod
On 2017/01/12 20:43:03, jdufault wrote:
> newxt => next

Done.

[jdufault, 2017-01-17 20:08:15]

lgtm

[xiyuan, 2017-01-17 20:13:32]

lgtm

[sammiequon, 2017-01-19 18:53:06]

The CQ bit was checked by sammiequon@chromium.org

[commit-bot: I haz the power, 2017-01-19 18:53:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-19 19:56:38]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484851986515880,
"parent_rev": "52cee9f3897946ddc4a6f0945421936e9079d185", "commit_rev":
"d0c3035247b102beb3b9121e58c65c650c2d2916"}

[commit-bot: I haz the power, 2017-01-19 19:57:50]

Description was changed from

==========
cros: Lock Screen: Fixed an issue with tab order on the lock screen.

The tabbing on the lock screen used to hit the header bar before the pin
keyboard. After this change the pin keyboard gets tabbed to with a caveat. The
root gets a focus before the buttons, thus having a extra step. I have a
solution but it is really hacky. I think having to press the tab key one extra
time is still better than having tab reach the header bar first. What do you
guys think?

BUG=680634
TEST=NONE
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
cros: Lock Screen: Fixed an issue with tab order on the lock screen.

The tabbing on the lock screen used to hit the header bar before the pin
keyboard. After this change the pin keyboard gets tabbed to with a caveat. The
root gets a focus before the buttons, thus having a extra step. I have a
solution but it is really hacky. I think having to press the tab key one extra
time is still better than having tab reach the header bar first. What do you
guys think?

BUG=680634
TEST=NONE
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2624383004
Cr-Commit-Position: refs/heads/master@{#444822}
Committed:
https://chromium.googlesource.com/chromium/src/+/d0c3035247b102beb3b9121e58c6...
==========

[commit-bot: I haz the power, 2017-01-19 19:57:51]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/d0c3035247b102beb3b9121e58c6...