third_party/WebKit/Source/core/paint/BoxClipper.cpp - Issue 2624383002: Apply SVG viewport clips in PaintLayer; paint background of replaced like boxes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/BoxClipper.cpp

Issue 2624383002: Apply SVG viewport clips in PaintLayer; paint background of replaced like boxes. (Closed)

Patch Set: none Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/paint/BoxClipper.cpp

diff --git a/third_party/WebKit/Source/core/paint/BoxClipper.cpp b/third_party/WebKit/Source/core/paint/BoxClipper.cpp

index 17ca2c8c1a28de154603cee5932ff6d1cc5ea56a..3d52f76b705525ea7f725bdb38acea8c55677ccf 100644

--- a/third_party/WebKit/Source/core/paint/BoxClipper.cpp

+++ b/third_party/WebKit/Source/core/paint/BoxClipper.cpp

@@ -19,8 +19,6 @@ namespace blink {

static bool boxNeedsClip(const LayoutBox& box) {

if (box.hasControlClip())

return true;

- if (box.isSVGRoot() && toLayoutSVGRoot(box).shouldApplyViewportClip())

pdr. 2017/01/13 22:09:36 Please move this down a few lines.

chrishtr 2017/01/13 22:14:22 Done. Also added a comment inspired by your catch.

- return true;

if (box.hasLayer() && box.layer()->isSelfPaintingLayer())

return false;

return box.hasOverflowClip() || box.styleRef().containsPaint();