Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(491)

Issue 2624333004: Simplify manifest-related code in Port to only support new format. (Closed)

Created:
3 years, 11 months ago by qyearsley
Modified:
3 years, 11 months ago
Reviewers:
jeffcarp
CC:
blink-reviews, chromium-reviews, Dirk Pranke
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Simplify manifest-related code in Port to only support new format. BUG=678077 Review-Url: https://codereview.chromium.org/2624333004 Cr-Commit-Position: refs/heads/master@{#443441} Committed: https://chromium.googlesource.com/chromium/src/+/b8c6519a9b138d12402e34fd305b9fab6f7b403e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -10 lines) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py View 2 chunks +5 lines, -10 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
qyearsley
3 years, 11 months ago (2017-01-12 19:37:43 UTC) #2
jeffcarp
lgtm
3 years, 11 months ago (2017-01-12 21:10:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2624333004/1
3 years, 11 months ago (2017-01-12 21:50:22 UTC) #5
commit-bot: I haz the power
3 years, 11 months ago (2017-01-13 01:38:59 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b8c6519a9b138d12402e34fd305b...

Powered by Google App Engine
This is Rietveld 408576698