Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Issue 2624323002: cc: remove virtual from Layer::SetContentsOpaque (Closed)

Created:
3 years, 11 months ago by dshwang
Modified:
3 years, 11 months ago
CC:
cc-bugs_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: remove virtual from Layer::SetContentsOpaque Any child classes don't override it. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2624323002 Cr-Commit-Position: refs/heads/master@{#443094} Committed: https://chromium.googlesource.com/chromium/src/+/cc027be804c76009cf6d45487839dc8843010f6f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M cc/layers/layer.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (9 generated)
dshwang
enne, could you review this simple cl?
3 years, 11 months ago (2017-01-11 23:16:46 UTC) #4
enne (OOO)
lgtm
3 years, 11 months ago (2017-01-11 23:22:36 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2624323002/1
3 years, 11 months ago (2017-01-11 23:51:10 UTC) #10
commit-bot: I haz the power
3 years, 11 months ago (2017-01-12 00:58:41 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/cc027be804c76009cf6d45487839...

Powered by Google App Engine
This is Rietveld 408576698