[Findit] Flake Checker: Get swarming task triggered by flake try jobs.

[Findit] Flake Checker: Get swarming task triggered by flake try jobs.

BUG=680192
Review-Url: https://codereview.chromium.org/2624313002
Committed: https://chromium.googlesource.com/infra/infra/+/5ed5e5871cfea866158879f0bac70b10e64f370a

[chanli, 2017-01-11 22:50:56]

chanli@chromium.org changed reviewers:
+ lijeffrey@chromium.org, stgao@chromium.org

[chanli, 2017-01-11 22:50:56]

This is the change at Findit side to get step_metadata from report and check
tasks to get the one with result.

This branch dependents on https://codereview.chromium.org/2630433002

[stgao, 2017-01-12 07:43:27]

https://codereview.chromium.org/2624313002/diff/1/appengine/findit/waterfall/...
File appengine/findit/waterfall/flake/process_flake_try_job_result_pipeline.py
(right):

https://codereview.chromium.org/2624313002/diff/1/appengine/findit/waterfall/...
appengine/findit/waterfall/flake/process_flake_try_job_result_pipeline.py:20:
task_ids = report.get('result', {}).get(revision, {}).get(
If there is only one task id, do we still have to query Swarming or Isolated
server?

If the test doesn't exist in the tested revision, should we just pick any task
id or return None?

[chanli, 2017-01-12 20:28:29]

https://codereview.chromium.org/2624313002/diff/1/appengine/findit/waterfall/...
File appengine/findit/waterfall/flake/process_flake_try_job_result_pipeline.py
(right):

https://codereview.chromium.org/2624313002/diff/1/appengine/findit/waterfall/...
appengine/findit/waterfall/flake/process_flake_try_job_result_pipeline.py:20:
task_ids = report.get('result', {}).get(revision, {}).get(
On 2017/01/12 07:43:27, stgao (slow on Monday) wrote:
> If there is only one task id, do we still have to query Swarming or Isolated
> server?

Good point. Just updated.

> 
> If the test doesn't exist in the tested revision, should we just pick any task
> id or return None?
If test doesn't exist, would there be swarming tasks?

[lijeffrey, 2017-01-13 02:08:49]

lgtm

https://codereview.chromium.org/2624313002/diff/40001/appengine/findit/waterf...
File
appengine/findit/waterfall/flake/test/process_flake_try_job_result_pipeline_test.py
(right):

https://codereview.chromium.org/2624313002/diff/40001/appengine/findit/waterf...
appengine/findit/waterfall/flake/test/process_flake_try_job_result_pipeline_test.py:1:
# Copyright 2017 The Chromium Authors. All rights reserved.
remember to rebase once my CL is landed

[stgao, 2017-01-13 02:18:19]

lgtm if my comment with example is addressed.

https://codereview.chromium.org/2624313002/diff/1/appengine/findit/waterfall/...
File appengine/findit/waterfall/flake/process_flake_try_job_result_pipeline.py
(right):

https://codereview.chromium.org/2624313002/diff/1/appengine/findit/waterfall/...
appengine/findit/waterfall/flake/process_flake_try_job_result_pipeline.py:20:
task_ids = report.get('result', {}).get(revision, {}).get(
On 2017/01/12 20:28:29, chanli wrote:
> On 2017/01/12 07:43:27, stgao (slow on Monday) wrote:
> > If there is only one task id, do we still have to query Swarming or Isolated
> > server?
> 
> Good point. Just updated.
> 
> > 
> > If the test doesn't exist in the tested revision, should we just pick any
task
> > id or return None?
> If test doesn't exist, would there be swarming tasks?

Example: a test is newly added in the suspected build number. Bisecting at
commits before the test being added will still run Swarming tasks, but all
Swarming tasks won't have any iteration data for the test.

[chanli, 2017-01-14 00:29:35]

The CQ bit was checked by chanli@chromium.org

[chanli, 2017-01-14 00:29:36]

The patchset sent to the CQ was uploaded after l-g-t-m from stgao@chromium.org,
lijeffrey@chromium.org
Link to the patchset: https://codereview.chromium.org/2624313002/#ps100001
(title: "update docstring")

[commit-bot: I haz the power, 2017-01-14 00:29:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-14 00:39:15]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1484353775558820,
"parent_rev": "e06c5bba2b62ac0781577f1102aa099a606eb454", "commit_rev":
"5ed5e5871cfea866158879f0bac70b10e64f370a"}

[commit-bot: I haz the power, 2017-01-14 00:39:18]

Description was changed from

==========
[Findit] Flake Checker: Get swarming task triggered by flake try jobs.

BUG=680192
==========

to

==========
[Findit] Flake Checker: Get swarming task triggered by flake try jobs.

BUG=680192

Review-Url: https://codereview.chromium.org/2624313002
Committed:
https://chromium.googlesource.com/infra/infra/+/5ed5e5871cfea866158879f0bac70...
==========

[commit-bot: I haz the power, 2017-01-14 00:39:23]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/infra/infra/+/5ed5e5871cfea866158879f0bac70...