Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 2624303002: add TEAM/COMPONENT information into OWNERS (Closed)

Created:
3 years, 11 months ago by ymzhang1
Modified:
3 years, 10 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, stgao, ymzhang1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

add TEAM/COMPONENT information into OWNERS Please help us to verify the TEAM/COMPONENT information. If the current information is incorrect, please suggest the correct team or component or None(if not applicable). BUG=679905 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2624303002 Cr-Commit-Position: refs/heads/master@{#444210} Committed: https://chromium.googlesource.com/chromium/src/+/aa99b0c20fc1a58fa7231c0f0a9d69dd4dbc3596

Patch Set 1 #

Total comments: 43

Patch Set 2 : correct component and remove wrong mailing list #

Total comments: 4

Patch Set 3 : add 8 new OWNERS files #

Total comments: 4

Patch Set 4 : Merge branch 'master' of https://chromium.googlesource.com/chromium/src into adding1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -0 lines) Patch
M chrome/browser/chooser_controller/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/extensions/OWNERS View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/extensions/OWNERS View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/media_galleries/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/renderer_host/OWNERS View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/resources/webstore_app/OWNERS View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/usb/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/common/extensions/OWNERS View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/renderer/extensions/OWNERS View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/renderer/resources/extensions/OWNERS View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/utility/extensions/OWNERS View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M components/device_event_log/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download
M device/usb/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download
M extensions/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M extensions/browser/api/hid/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download
M extensions/browser/api/serial/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download
M extensions/browser/api/socket/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download
M extensions/browser/api/usb/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download
M services/device/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/webusb/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/libudev/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/usb_ids/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download
M tools/usb_gadget/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (8 generated)
ymzhang1
Hello, We are adding COMPONENT/TEAM information into OWNERS file. Would you mind helping us verify ...
3 years, 11 months ago (2017-01-11 22:40:20 UTC) #2
Reilly Grant (use Gerrit)
https://codereview.chromium.org/2624303002/diff/1/chrome/browser/OWNERS File chrome/browser/OWNERS (right): https://codereview.chromium.org/2624303002/diff/1/chrome/browser/OWNERS#newcode92 chrome/browser/OWNERS:92: # COMPONENT: Internals>Network This directory is so high level ...
3 years, 11 months ago (2017-01-11 22:59:20 UTC) #4
stgao
BTW, once a new patch is uploaded and needs reviewing again, you will have to ...
3 years, 11 months ago (2017-01-12 02:28:15 UTC) #6
Reilly Grant (use Gerrit)
https://codereview.chromium.org/2624303002/diff/20001/services/device/OWNERS File services/device/OWNERS (right): https://codereview.chromium.org/2624303002/diff/20001/services/device/OWNERS#newcode5 services/device/OWNERS:5: # COMPONENT: IO>USB My mistake, this is another top-level ...
3 years, 11 months ago (2017-01-12 03:05:08 UTC) #7
ymzhang1
https://codereview.chromium.org/2624303002/diff/1/chrome/browser/OWNERS File chrome/browser/OWNERS (right): https://codereview.chromium.org/2624303002/diff/1/chrome/browser/OWNERS#newcode92 chrome/browser/OWNERS:92: # COMPONENT: Internals>Network On 2017/01/11 22:59:18, Reilly Grant wrote: ...
3 years, 11 months ago (2017-01-12 18:12:44 UTC) #8
ymzhang1
Add 8 OWNERS file. TODO: update services/device/OWNERS.
3 years, 11 months ago (2017-01-12 18:50:51 UTC) #10
sshruthi1
On 2017/01/12 18:50:51, ymzhang1 wrote: > Add 8 OWNERS file. > > TODO: update services/device/OWNERS. ...
3 years, 11 months ago (2017-01-13 23:19:08 UTC) #11
Reilly Grant (use Gerrit)
https://codereview.chromium.org/2624303002/diff/40001/chrome/browser/renderer_host/OWNERS File chrome/browser/renderer_host/OWNERS (right): https://codereview.chromium.org/2624303002/diff/40001/chrome/browser/renderer_host/OWNERS#newcode21 chrome/browser/renderer_host/OWNERS:21: # COMPONENT: UI>Accessibility This directory is rather high level ...
3 years, 11 months ago (2017-01-17 19:35:29 UTC) #12
ymzhang1
https://codereview.chromium.org/2624303002/diff/40001/chrome/browser/renderer_host/OWNERS File chrome/browser/renderer_host/OWNERS (right): https://codereview.chromium.org/2624303002/diff/40001/chrome/browser/renderer_host/OWNERS#newcode21 chrome/browser/renderer_host/OWNERS:21: # COMPONENT: UI>Accessibility On 2017/01/17 19:35:29, Reilly Grant wrote: ...
3 years, 11 months ago (2017-01-17 23:26:55 UTC) #13
Reilly Grant (use Gerrit)
lgtm
3 years, 11 months ago (2017-01-17 23:30:10 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2624303002/60001
3 years, 11 months ago (2017-01-17 23:32:18 UTC) #16
commit-bot: I haz the power
Committed patchset #4 (id:60001) as https://chromium.googlesource.com/chromium/src/+/aa99b0c20fc1a58fa7231c0f0a9d69dd4dbc3596
3 years, 11 months ago (2017-01-18 00:46:50 UTC) #19
Wez
3 years, 10 months ago (2017-02-07 22:30:13 UTC) #21
Message was sent while issue was closed.
Hallo thakis@chromium.org!
Due to a depot_tools patch which mistakenly removed the OWNERS check for
non-source files (see crbug.com/684270), the following files landed in this CL
and need a retrospective rubber-stamp review from you:
	chrome/browser/renderer_host/OWNERS
Thanks,
Wez

Powered by Google App Engine
This is Rietveld 408576698