Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(734)

Issue 2624283002: Minor comment updates to CertVerify related code. (Closed)

Created:
3 years, 11 months ago by eroman
Modified:
3 years, 11 months ago
Reviewers:
Ryan Sleevi
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Minor comment updates to CertVerify related code. Also removes an oddity with CertVerifyResult::operator== by handling the null case instead of documenting it as invalid. operator== was only used by a unit-test (components/cronet/android/cert/cert_verifier_cache_serializer_unittest.cc), so this generalization does not weaken nullability guarantees. Review-Url: https://codereview.chromium.org/2624283002 Cr-Commit-Position: refs/heads/master@{#443054} Committed: https://chromium.googlesource.com/chromium/src/+/0f71ff05b2c969aa3074d1b7e80da003051dbd15

Patch Set 1 #

Patch Set 2 : phrasing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M net/cert/cert_verify_result.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M net/cert/cert_verify_result.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/cert/test_root_certs.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (12 generated)
eroman
3 years, 11 months ago (2017-01-11 20:22:02 UTC) #7
Ryan Sleevi
lgtm
3 years, 11 months ago (2017-01-11 20:31:07 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2624283002/20001
3 years, 11 months ago (2017-01-11 22:19:40 UTC) #13
commit-bot: I haz the power
3 years, 11 months ago (2017-01-11 23:38:31 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/0f71ff05b2c969aa3074d1b7e80d...

Powered by Google App Engine
This is Rietveld 408576698