Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(595)

Issue 2624263004: Re-enable NavigationTestCase on device. (Closed)

Created:
3 years, 11 months ago by baxley
Modified:
3 years, 11 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-enable NavigationTestCase on device. These tests are affected by crashes in the context menu tests. With these tests disabled. They could also be affected by alerts, but We now skip tests with alerts on EG tests. BUG=675400 Review-Url: https://codereview.chromium.org/2624263004 Cr-Commit-Position: refs/heads/master@{#443310} Committed: https://chromium.googlesource.com/chromium/src/+/0cf2888a1c34851785f60e914278cc07229222cb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -16 lines) Patch
M ios/web/shell/test/navigation_egtest.mm View 2 chunks +2 lines, -16 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
baxley
These should be fixed now. They were adversely affected when run after the context menu ...
3 years, 11 months ago (2017-01-12 17:59:53 UTC) #2
Eugene But (OOO till 7-30)
lgtm
3 years, 11 months ago (2017-01-12 18:03:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2624263004/1
3 years, 11 months ago (2017-01-12 18:24:42 UTC) #5
commit-bot: I haz the power
3 years, 11 months ago (2017-01-12 19:00:38 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0cf2888a1c34851785f60e914278...

Powered by Google App Engine
This is Rietveld 408576698