Add more WebVR layout tests and fix small issues they found

Add more WebVR layout tests and fix small issues they found

Adds several additional WebVR layout tests.

Refactors the WebVR Mojo mocking to more closely emulate the actual
actual implementation.

Fixes several issues in the WebVR source code that were encountered by these
tests.

BUG=679952, 679288
Review-Url: https://codereview.chromium.org/2624263003
Cr-Commit-Position: refs/heads/master@{#443485}
Committed: https://chromium.googlesource.com/chromium/src/+/b7f90cae827044cfb2280c8382d993848ef33340

[bsheedy, 2017-01-11 22:56:49]

bsheedy@chromium.org changed reviewers:
+ bajones@chromium.org

[bsheedy, 2017-01-11 22:56:50]

PTAL

https://codereview.chromium.org/2624263003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/vr/VRDisplay.cpp (right):

https://codereview.chromium.org/2624263003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/vr/VRDisplay.cpp:329: if (!layers[0].source())
{
Changed to address https://bugs.chromium.org/p/chromium/issues/detail?id=679952

[haraken, 2017-01-11 23:47:00]

haraken@chromium.org changed reviewers:
+ haraken@chromium.org

[haraken, 2017-01-11 23:47:01]

NavigatorVR LGTM

https://codereview.chromium.org/2624263003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/vr/NavigatorVR.cpp (right):

https://codereview.chromium.org/2624263003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/vr/NavigatorVR.cpp:113: if
(!(host()->frame()))

Sorry... I think this is a bug my CL injected.

[bajones, 2017-01-13 00:42:27]

LGTM

[bsheedy, 2017-01-13 01:46:08]

The CQ bit was checked by bsheedy@chromium.org

[commit-bot: I haz the power, 2017-01-13 01:47:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-13 04:14:47]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1484271968010810,
"parent_rev": "a666354708b589398cf89971d2404f5300de8b23", "commit_rev":
"b7f90cae827044cfb2280c8382d993848ef33340"}

[commit-bot: I haz the power, 2017-01-13 04:15:45]

Description was changed from

==========
Add more WebVR layout tests and fix small issues they found

Adds several additional WebVR layout tests.

Refactors the WebVR Mojo mocking to more closely emulate the actual
actual implementation.

Fixes several issues in the WebVR source code that were encountered by these
tests.

BUG=679952,679288
==========

to

==========
Add more WebVR layout tests and fix small issues they found

Adds several additional WebVR layout tests.

Refactors the WebVR Mojo mocking to more closely emulate the actual
actual implementation.

Fixes several issues in the WebVR source code that were encountered by these
tests.

BUG=679952,679288

Review-Url: https://codereview.chromium.org/2624263003
Cr-Commit-Position: refs/heads/master@{#443485}
Committed:
https://chromium.googlesource.com/chromium/src/+/b7f90cae827044cfb2280c8382d9...
==========

[commit-bot: I haz the power, 2017-01-13 04:15:46]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/b7f90cae827044cfb2280c8382d9...