SearchEngineTabHelper: avoid calling TemplateURL::GenerateFaviconURL with empty URL.

SearchEngineTabHelper: avoid calling TemplateURL::GenerateFaviconURL with empty URL.

In some cases, it tried to generate favicon URL using the referrer URL of a
navigation, but referrer URL could be empty which triggered a DCHECK in
TemplateURL::GenerateFaviconURL.

BUG=678502
Review-Url: https://codereview.chromium.org/2624263002
Cr-Commit-Position: refs/heads/master@{#443017}
Committed: https://chromium.googlesource.com/chromium/src/+/61ea83dfd086b18d20e746d7f61bd05b7a933aa2

[yzshen1, 2017-01-11 18:16:06]

Patchset #1 (id:1) has been deleted

[yzshen1, 2017-01-11 18:16:18]

The CQ bit was checked by yzshen@chromium.org to run a CQ dry run

[yzshen1, 2017-01-11 18:16:33]

yzshen@chromium.org changed reviewers:
+ sky@chromium.org

[yzshen1, 2017-01-11 18:16:33]

Hi, Scott.

Would you please take a look? Thanks!

[commit-bot: I haz the power, 2017-01-11 18:16:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 18:56:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-11 18:56:22]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[sky, 2017-01-11 19:02:40]

LGTM

[yzshen1, 2017-01-11 19:03:34]

The CQ bit was checked by yzshen@chromium.org

[commit-bot: I haz the power, 2017-01-11 19:04:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 22:25:40]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484161414943430,
"parent_rev": "3a6eca3ccd3baaba2e1690ed02757d6281123c44", "commit_rev":
"61ea83dfd086b18d20e746d7f61bd05b7a933aa2"}

[commit-bot: I haz the power, 2017-01-11 22:26:12]

Description was changed from

==========
SearchEngineTabHelper: avoid calling TemplateURL::GenerateFaviconURL with empty
URL.

In some cases, it tried to generate favicon URL using the referrer URL of a
navigation, but referrer URL could be empty which triggered a DCHECK in
TemplateURL::GenerateFaviconURL.

BUG=678502
==========

to

==========
SearchEngineTabHelper: avoid calling TemplateURL::GenerateFaviconURL with empty
URL.

In some cases, it tried to generate favicon URL using the referrer URL of a
navigation, but referrer URL could be empty which triggered a DCHECK in
TemplateURL::GenerateFaviconURL.

BUG=678502

Review-Url: https://codereview.chromium.org/2624263002
Cr-Commit-Position: refs/heads/master@{#443017}
Committed:
https://chromium.googlesource.com/chromium/src/+/61ea83dfd086b18d20e746d7f61b...
==========

[commit-bot: I haz the power, 2017-01-11 22:26:13]

Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/61ea83dfd086b18d20e746d7f61b...