Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 2624233002: Rename incognito and simple_smoke to be better named and organized. (Closed)

Created:
3 years, 11 months ago by Robert Ogden
Modified:
3 years, 11 months ago
Reviewers:
sclittle
CC:
chromium-reviews, tbansal+watch-data-reduction-proxy_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename incognito and simple_smoke to be better named and organized. R=sclittle BUG=679424 Review-Url: https://codereview.chromium.org/2624233002 Cr-Commit-Position: refs/heads/master@{#442982} Committed: https://chromium.googlesource.com/chromium/src/+/074a68c26c2ced7eef6e6a67d8f6a3bf009e1ce8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-2 lines, -78 lines) Patch
A + tools/chrome_proxy/webdriver/examples.py View 0 chunks +-1 lines, --1 lines 0 comments Download
D tools/chrome_proxy/webdriver/incognito.py View 1 chunk +0 lines, -22 lines 0 comments Download
D tools/chrome_proxy/webdriver/simple_smoke.py View 1 chunk +0 lines, -58 lines 0 comments Download
A + tools/chrome_proxy/webdriver/smoke.py View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Robert Ogden
3 years, 11 months ago (2017-01-11 16:11:27 UTC) #1
sclittle
On 2017/01/11 16:11:27, Robert Ogden wrote: You deleted a bunch of files here - did ...
3 years, 11 months ago (2017-01-11 18:11:39 UTC) #2
sclittle
On 2017/01/11 16:11:27, Robert Ogden wrote: You deleted a bunch of files here - did ...
3 years, 11 months ago (2017-01-11 18:11:41 UTC) #3
Robert Ogden
On 2017/01/11 18:11:41, sclittle wrote: > On 2017/01/11 16:11:27, Robert Ogden wrote: > > You ...
3 years, 11 months ago (2017-01-11 19:04:55 UTC) #4
sclittle
Ah, I see, OK. LGTM
3 years, 11 months ago (2017-01-11 19:11:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2624233002/1
3 years, 11 months ago (2017-01-11 19:20:44 UTC) #7
commit-bot: I haz the power
3 years, 11 months ago (2017-01-11 19:36:11 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/074a68c26c2ced7eef6e6a67d8f6...

Powered by Google App Engine
This is Rietveld 408576698