Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(758)

Issue 2624213004: Fix setting css-wide keywords on registered custom properties (Closed)

Created:
3 years, 11 months ago by Timothy Loh
Modified:
3 years, 11 months ago
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, chromium-reviews, dglazkov+blink, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix setting css-wide keywords on registered custom properties This patch fixes setting of css-wide keywords on registered custom properties, which was broken by crrev.com/2607403002. BUG=679627 Review-Url: https://codereview.chromium.org/2624213004 Cr-Commit-Position: refs/heads/master@{#443204} Committed: https://chromium.googlesource.com/chromium/src/+/9b7705c2d31d7536d7fee713c24fd598a62b63c7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M third_party/WebKit/LayoutTests/custom-properties/registered-property-cssom.html View 2 chunks +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSParserImpl.cpp View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
Timothy Loh
3 years, 11 months ago (2017-01-12 06:32:16 UTC) #4
alancutter (OOO until 2018)
lgtm
3 years, 11 months ago (2017-01-12 07:03:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2624213004/1
3 years, 11 months ago (2017-01-12 08:57:17 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-12 10:52:52 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9b7705c2d31d7536d7fee713c24f...

Powered by Google App Engine
This is Rietveld 408576698