Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 2624213002: net: remove AppendHeaderIfMissing() from HttpUtil (Closed)

Created:
3 years, 11 months ago by tfarina
Modified:
3 years, 11 months ago
Reviewers:
mmenke
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

net: remove AppendHeaderIfMissing() from HttpUtil The last usage of this method was removed by commit 451a66360d2c: ("rlz: get rid of the call to AppendHeaderIfMissing()"). This also made possible to remove HasHeader() as AppendHeaderIfMissing() were the only client of it. With removing HasHeader() method from HttpUtil we fixed the Darin's TODO. BUG=488593 TEST=net_unittests R=mmenke@chromium.org Review-Url: https://codereview.chromium.org/2624213002 Cr-Commit-Position: refs/heads/master@{#442965} Committed: https://chromium.googlesource.com/chromium/src/+/0c8f272908a7a7ea0583d7b5768740d42b790457

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -65 lines) Patch
M net/http/http_util.h View 2 chunks +0 lines, -11 lines 0 comments Download
M net/http/http_util.cc View 3 chunks +3 lines, -34 lines 0 comments Download
M net/http/http_util_unittest.cc View 1 chunk +0 lines, -20 lines 0 comments Download

Messages

Total messages: 10 (7 generated)
mmenke
Looks great, LGTM!
3 years, 11 months ago (2017-01-11 16:29:46 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2624213002/1
3 years, 11 months ago (2017-01-11 18:42:24 UTC) #7
commit-bot: I haz the power
3 years, 11 months ago (2017-01-11 18:48:09 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0c8f272908a7a7ea0583d7b57687...

Powered by Google App Engine
This is Rietveld 408576698