Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 2624203003: MD Settings: fix presentation of sync page (Closed)

Created:
3 years, 11 months ago by Dan Beam
Modified:
3 years, 11 months ago
Reviewers:
tommycli
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: fix presentation of sync page When moving from checkboxes -> toggles, I unwrapped the label text of UIs using <paper-checkbox hidden=[[...]]>...</paper-checkbox> to <div>...</div> <paper-toggle-button hidden=[[...]]></paper-toggle-button> I forgot to move the hidden=[[]] bindings, and only the toggle would get hidden on platforms that don't support the data type. R=tommycli@chromium.org BUG=none CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2624203003 Cr-Commit-Position: refs/heads/master@{#443070} Committed: https://chromium.googlesource.com/chromium/src/+/ccb031cf7c5a129b7059e6b5855f16af12f2a9f3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -20 lines) Patch
M chrome/browser/resources/settings/people_page/sync_page.html View 2 chunks +20 lines, -20 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Dan Beam
3 years, 11 months ago (2017-01-11 22:29:43 UTC) #2
tommycli
fine with me lgtm
3 years, 11 months ago (2017-01-11 22:32:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2624203003/1
3 years, 11 months ago (2017-01-11 22:40:17 UTC) #5
commit-bot: I haz the power
3 years, 11 months ago (2017-01-12 00:14:21 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ccb031cf7c5a129b7059e6b5855f...

Powered by Google App Engine
This is Rietveld 408576698