Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issue 2624183003: Suppress lint warnings for data_reduction_promo_summary string (Closed)

Created:
3 years, 11 months ago by megjablon
Modified:
3 years, 11 months ago
Reviewers:
perezju, agrieve
CC:
chromium-reviews, mikecase+watch_chromium.org, jbudorick+watch_chromium.org, agrieve+watch_chromium.org, dimu1, perezju
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Suppress lint warnings for data_reduction_promo_summary string Suppress lint warnings for translations of the data_reduction_promo_summary string in values-pt-rBR/android_chrome_strings.xml and values-cs/android_chrome_strings.xml BUG=680246 Review-Url: https://codereview.chromium.org/2624183003 Cr-Commit-Position: refs/heads/master@{#443301} Committed: https://chromium.googlesource.com/chromium/src/+/ac40ecf4ebcc9682460cdeb693c482efb1d45e55

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M build/android/lint/suppressions.xml View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
megjablon
PTAL, thanks!
3 years, 11 months ago (2017-01-11 23:31:04 UTC) #2
perezju
I'm not really familiar with this file. +Andrew, maybe you can have a look?
3 years, 11 months ago (2017-01-12 09:35:20 UTC) #5
agrieve
On 2017/01/12 09:35:20, perezju wrote: > I'm not really familiar with this file. +Andrew, maybe ...
3 years, 11 months ago (2017-01-12 16:22:45 UTC) #6
agrieve
On 2017/01/12 09:35:20, perezju wrote: > I'm not really familiar with this file. +Andrew, maybe ...
3 years, 11 months ago (2017-01-12 16:22:45 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2624183003/1
3 years, 11 months ago (2017-01-12 17:58:16 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-12 18:40:47 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ac40ecf4ebcc9682460cdeb693c4...

Powered by Google App Engine
This is Rietveld 408576698