Remainder of V8 removal

Remainder of V8 removal

chrome.dll:
before: 48,394,752
after:  34,550,272
== -13,844,480 bytes

is_debug = false
is_chrome_branded = true
is_component_build = false
symbol_level = 2
is_official_build = true
target_cpu = "x86"

BUG=581766

[scottmg, 2017-01-12 06:53:03]

Description was changed from

==========
Remainder of V8 removal

BUG=581766
==========

to

==========
Remainder of V8 removal

after:  34,550,272

BUG=581766
==========

[scottmg, 2017-01-12 07:37:05]

Description was changed from

==========
Remainder of V8 removal

after:  34,550,272

BUG=581766
==========

to

==========
Remainder of V8 removal

chrome.dll
before: 48,394,752
after:  34,550,272

is_debug = false
is_chrome_branded = true
is_component_build = false
symbol_level = 2
is_official_build = true
target_cpu = "x86"

BUG=581766
==========

[scottmg, 2017-01-12 07:37:53]

Description was changed from

==========
Remainder of V8 removal

chrome.dll
before: 48,394,752
after:  34,550,272

is_debug = false
is_chrome_branded = true
is_component_build = false
symbol_level = 2
is_official_build = true
target_cpu = "x86"

BUG=581766
==========

to

==========
Remainder of V8 removal

chrome.dll
before: 48,394,752
after:  34,550,272
== -13,844,480 bytes

is_debug = false
is_chrome_branded = true
is_component_build = false
symbol_level = 2
is_official_build = true
target_cpu = "x86"

BUG=581766
==========

[scottmg, 2017-01-12 07:38:08]

Description was changed from

==========
Remainder of V8 removal

chrome.dll
before: 48,394,752
after:  34,550,272
== -13,844,480 bytes

is_debug = false
is_chrome_branded = true
is_component_build = false
symbol_level = 2
is_official_build = true
target_cpu = "x86"

BUG=581766
==========

to

==========
Remainder of V8 removal

chrome.dll:
before: 48,394,752
after:  34,550,272
== -13,844,480 bytes

is_debug = false
is_chrome_branded = true
is_component_build = false
symbol_level = 2
is_official_build = true
target_cpu = "x86"

BUG=581766
==========

[brucedawson, 2017-01-12 23:28:00]

I'm confused by the sizes that you're seeing. On today's x86 canary chrome.dll
is 40,665,944 bytes. The one setting that you're missing (oh the land mines that
we leave - this one needs fixing) is full_wpo_on_official, although I have a
hard time believing that that could make an almost 8 MB difference. Here are my
settings which give me a canary-comparable binary size:

is_chrome_branded = true
is_component_build = false
is_debug = false
target_cpu = "x86"
is_official_build = true
full_wpo_on_official = true

[scottmg, 2017-01-12 23:30:55]

On 2017/01/12 23:28:00, brucedawson wrote:
> I'm confused by the sizes that you're seeing. On today's x86 canary chrome.dll
> is 40,665,944 bytes. The one setting that you're missing (oh the land mines
that
> we leave - this one needs fixing) is full_wpo_on_official, although I have a
> hard time believing that that could make an almost 8 MB difference. Here are
my
> settings which give me a canary-comparable binary size:
> 
> is_chrome_branded = true
> is_component_build = false
> is_debug = false
> target_cpu = "x86"
> is_official_build = true
> full_wpo_on_official = true

Hmm, that could be it I guess. It's possible it manages to drop much of mostly
unused copy of blink, etc when full_wpo_on_official is on?

[scottmg, 2017-01-12 23:32:06]

On 2017/01/12 23:30:55, scottmg wrote:
> On 2017/01/12 23:28:00, brucedawson wrote:
> > I'm confused by the sizes that you're seeing. On today's x86 canary
chrome.dll
> > is 40,665,944 bytes. The one setting that you're missing (oh the land mines
> that
> > we leave - this one needs fixing) is full_wpo_on_official, although I have a
> > hard time believing that that could make an almost 8 MB difference. Here are
> my
> > settings which give me a canary-comparable binary size:
> > 
> > is_chrome_branded = true
> > is_component_build = false
> > is_debug = false
> > target_cpu = "x86"
> > is_official_build = true
> > full_wpo_on_official = true
> 
> Hmm, that could be it I guess. It's possible it manages to drop much of mostly
> unused copy of blink, etc when full_wpo_on_official is on?

(I'm on clang x64 canary so I didn't have one around to compare.)

[scottmg, 2017-01-12 23:49:59]

scottmg@chromium.org changed reviewers:
+ brucedawson@chromium.org, sebmarchand@chromium.org

[scottmg, 2017-01-12 23:50:40]

On 2017/01/12 23:28:00, brucedawson wrote:
> I'm confused by the sizes that you're seeing. On today's x86 canary chrome.dll
> is 40,665,944 bytes. The one setting that you're missing (oh the land mines
that
> we leave - this one needs fixing) is full_wpo_on_official, although I have a
> hard time believing that that could make an almost 8 MB difference. Here are
my
> settings which give me a canary-comparable binary size:
> 
> is_chrome_branded = true
> is_component_build = false
> is_debug = false
> target_cpu = "x86"
> is_official_build = true
> full_wpo_on_official = true

Why does full_wpo_on_official need to be here
https://cs.chromium.org/chromium/src/build/config/compiler/BUILD.gn?rcl=0&l=1378
? Isn't is_official_build enough there?

[Sébastien Marchand, 2017-01-13 00:07:29]

I've opened https://bugs.chromium.org/p/chromium/issues/detail?id=680795 to fix
this full_wpo_on_official madness, I really want to get rid of this flag but it
doesn't come for free :(

[scottmg, 2017-01-13 05:24:33]

On 2017/01/12 23:30:55, scottmg wrote:
> On 2017/01/12 23:28:00, brucedawson wrote:
> > I'm confused by the sizes that you're seeing. On today's x86 canary
chrome.dll
> > is 40,665,944 bytes. The one setting that you're missing (oh the land mines
> that
> > we leave - this one needs fixing) is full_wpo_on_official, although I have a
> > hard time believing that that could make an almost 8 MB difference. Here are
> my
> > settings which give me a canary-comparable binary size:
> > 
> > is_chrome_branded = true
> > is_component_build = false
> > is_debug = false
> > target_cpu = "x86"
> > is_official_build = true
> > full_wpo_on_official = true
> 
> Hmm, that could be it I guess. It's possible it manages to drop much of mostly
> unused copy of blink, etc when full_wpo_on_official is on?

Yeah, it looks like full_wpo_on_official completely changes things.

chrome.dll official non-full_wpo:
before: 48,394,752
after: 34,550,272

chrome.dll official full_wpo:
before:  40,519,168
after: 40,512,000

[scottmg, 2017-01-13 05:25:48]

On 2017/01/13 05:24:33, scottmg wrote:
> On 2017/01/12 23:30:55, scottmg wrote:
> > On 2017/01/12 23:28:00, brucedawson wrote:
> > > I'm confused by the sizes that you're seeing. On today's x86 canary
> chrome.dll
> > > is 40,665,944 bytes. The one setting that you're missing (oh the land
mines
> > that
> > > we leave - this one needs fixing) is full_wpo_on_official, although I have
a
> > > hard time believing that that could make an almost 8 MB difference. Here
are
> > my
> > > settings which give me a canary-comparable binary size:
> > > 
> > > is_chrome_branded = true
> > > is_component_build = false
> > > is_debug = false
> > > target_cpu = "x86"
> > > is_official_build = true
> > > full_wpo_on_official = true
> > 
> > Hmm, that could be it I guess. It's possible it manages to drop much of
mostly
> > unused copy of blink, etc when full_wpo_on_official is on?
> 
> Yeah, it looks like full_wpo_on_official completely changes things.
> 
> chrome.dll official non-full_wpo:
> before: 48,394,752
> after: 34,550,272
> 
> chrome.dll official full_wpo:
> before:  40,519,168
> after: 40,512,000

Er, those numbers are just breaking the Blink dep, not v8, so not completely
comparable. But the two "before"s are roughly comparable.