Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(556)

Unified Diff: chrome/BUILD.gn

Issue 2624163003: Remainder of V8 removal (Closed)
Patch Set: . Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/DEPS » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/BUILD.gn
diff --git a/chrome/BUILD.gn b/chrome/BUILD.gn
index a4044b8341f201c4ea18cdb061fb7bf3240b1ff5..893052ef10e370d0f24a984a1b9558896c58f355 100644
--- a/chrome/BUILD.gn
+++ b/chrome/BUILD.gn
@@ -1221,10 +1221,11 @@ group("browser_dependencies") {
# Note that the blink_headers target is OK, so we can't do a wildcard for
# all blink targets.
"//third_party/WebKit/public:blink",
- # TODO(brettw) bug 581766: V8 should not be linked into the browser
- # process, and then we can enable this. When testing whether you can
- # enable this, run with a non-component build.
- #"//v8/*",
+
+ # V8 shouldn't be in the browser, however, one header only target
+ # containing the version is allowed, //v8:v8_version. Because of this, we
+ # can't disallow //v8:* here which we would otherwise want.
+ "//v8:v8",
]
}
}
« no previous file with comments | « no previous file | chrome/DEPS » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698