Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(929)

Issue 2624143005: [layoutng] Use the override width even when we're not a flex item (Closed)

Created:
3 years, 11 months ago by cbiesinger
Modified:
3 years, 11 months ago
Reviewers:
atotic, eae
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[layoutng] Use the override width even when we're not a flex item (And also use it for positioned boxes) We want to use this for layoutng/legacy interop. For legacy layout, there should be no change in behavior because flexbox is currently the only caller of this function: https://cs.chromium.org/search/?q=setOverrideLogicalContentWidth&sq=package:chromium&type=cs Interestingly, the height version did not have this limitation already. This patch also deleted an outdated FIXME comment. R=atotic@chromium.org,eae@chromium.org BUG=635619 Review-Url: https://codereview.chromium.org/2624143005 Cr-Commit-Position: refs/heads/master@{#443056} Committed: https://chromium.googlesource.com/chromium/src/+/513f1f02c5c928367006c600cd1098f6315654ca

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -11 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutBox.cpp View 2 chunks +6 lines, -11 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
cbiesinger
3 years, 11 months ago (2017-01-11 21:44:38 UTC) #1
eae
LGTM
3 years, 11 months ago (2017-01-11 22:03:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2624143005/1
3 years, 11 months ago (2017-01-11 22:10:37 UTC) #8
atotic
lgtm
3 years, 11 months ago (2017-01-11 22:46:07 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-11 23:45:50 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/513f1f02c5c928367006c600cd10...

Powered by Google App Engine
This is Rietveld 408576698