Add --test_filter with * wildcard functionality for classname and

Add --test_filter with * wildcard functionality for classname and
methodname.

Example:
  --test_filter=Hello.W*
  Matches classname='Hello' and methodname='W*'

BUG=669956
Review-Url: https://codereview.chromium.org/2624133003
Cr-Commit-Position: refs/heads/master@{#443004}
Committed: https://chromium.googlesource.com/chromium/src/+/2afc205491aaace614ef521ce636fc59d0a83e8b

[Robert Ogden, 2017-01-11 17:22:08]

robertogden@chromium.org changed reviewers:
+ ryansturm@chromium.org

[RyanSturm, 2017-01-11 17:42:10]

https://codereview.chromium.org/2624133003/diff/1/tools/chrome_proxy/webdrive...
File tools/chrome_proxy/webdriver/common.py (right):

https://codereview.chromium.org/2624133003/diff/1/tools/chrome_proxy/webdrive...
tools/chrome_proxy/webdriver/common.py:35: return
re.match('^[A-Za-z_0-9\*]+\.[A-Za-z_0-9\*]+$', v).group(0)
This should accept TestClass* in addition to TestClass.TestCase*, so maybe
^([A-Za-z_0-9\*]+\.)?[A-Za-z_0-9\*]+$ (writing TestClass*.* is annoying and not
the behavior of gtest_filter)

Alternatively, I'm somewhat confident that gtest_filter has to have an exact
starting match with an optional trailing * (no intermediary *), so a very weak
form of regex. If you want to do that behavior, nobody will complain I believe.

In that case you would want to match ^([A-Za-z_0-9\.]+*?$.

https://codereview.chromium.org/2624133003/diff/1/tools/chrome_proxy/webdrive...
tools/chrome_proxy/webdriver/common.py:564: test_filter_re =
flags.test_filter.replace('.', r'\.').replace('*', '.*')
See comment above. I think if you do the last approach, this should still work.

[Robert Ogden, 2017-01-11 19:19:45]

https://codereview.chromium.org/2624133003/diff/1/tools/chrome_proxy/webdrive...
File tools/chrome_proxy/webdriver/common.py (right):

https://codereview.chromium.org/2624133003/diff/1/tools/chrome_proxy/webdrive...
tools/chrome_proxy/webdriver/common.py:35: return
re.match('^[A-Za-z_0-9\*]+\.[A-Za-z_0-9\*]+$', v).group(0)
On 2017/01/11 17:42:10, Ryan Sturm wrote:
> This should accept TestClass* in addition to TestClass.TestCase*, so maybe
> ^([A-Za-z_0-9\*]+\.)?[A-Za-z_0-9\*]+$ (writing TestClass*.* is annoying and
not
> the behavior of gtest_filter)
> 
> Alternatively, I'm somewhat confident that gtest_filter has to have an exact
> starting match with an optional trailing * (no intermediary *), so a very weak
> form of regex. If you want to do that behavior, nobody will complain I
believe.
> 
> In that case you would want to match ^([A-Za-z_0-9\.]+*?$.

Took the first option. It seems cleaner to me.

https://codereview.chromium.org/2624133003/diff/1/tools/chrome_proxy/webdrive...
tools/chrome_proxy/webdriver/common.py:564: test_filter_re =
flags.test_filter.replace('.', r'\.').replace('*', '.*')
On 2017/01/11 17:42:10, Ryan Sturm wrote:
> See comment above. I think if you do the last approach, this should still
work.

Acknowledged.

[RyanSturm, 2017-01-11 20:04:55]

lgtm

[Robert Ogden, 2017-01-11 20:45:41]

The CQ bit was checked by robertogden@chromium.org

[commit-bot: I haz the power, 2017-01-11 20:46:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 22:09:53]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484167541505370,
"parent_rev": "b664383006661b34cbe214ace8d488e684cb6670", "commit_rev":
"2afc205491aaace614ef521ce636fc59d0a83e8b"}

[commit-bot: I haz the power, 2017-01-11 22:10:26]

Description was changed from

==========
Add --test_filter with * wildcard functionality for classname and
methodname.

Example:
  --test_filter=Hello.W*
  Matches classname='Hello' and methodname='W*'

BUG=669956
==========

to

==========
Add --test_filter with * wildcard functionality for classname and
methodname.

Example:
  --test_filter=Hello.W*
  Matches classname='Hello' and methodname='W*'

BUG=669956

Review-Url: https://codereview.chromium.org/2624133003
Cr-Commit-Position: refs/heads/master@{#443004}
Committed:
https://chromium.googlesource.com/chromium/src/+/2afc205491aaace614ef521ce636...
==========

[commit-bot: I haz the power, 2017-01-11 22:10:28]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/2afc205491aaace614ef521ce636...