Chromium Code Reviews| Index: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/servers/wptserve.py |
| diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/servers/wptserve.py b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/servers/wptserve.py |
| index b4635b98faedb6c18ae90afc11f49dc4e0147121..d2e7b0bc1a11dbe1540c17b65268904241716c44 100644 |
| --- a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/servers/wptserve.py |
| +++ b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/servers/wptserve.py |
| @@ -49,7 +49,6 @@ class WPTServe(server_base.ServerBase): |
| self._cwd = path_to_wpt_root |
| self._env = port_obj.host.environ.copy() |
| self._env.update({'PYTHONPATH': path_to_thirdparty}) |
| - self._keep_process_reference = True |
|
qyearsley
2017/01/11 23:52:23
This is also unused, but removing this line is not
|
| self._start_cmd = start_cmd |
| expiration_date = datetime.date(2025, 1, 4) |
| @@ -58,20 +57,3 @@ class WPTServe(server_base.ServerBase): |
| 'Pre-generated keys and certificates are going to be expired at %s.' |
| ' Please re-generate them by following steps in %s/README.chromium.' |
| % (expiration_date.strftime('%b %d %Y'), path_to_wpt_support)) |
| - |
| - def _stop_running_server(self): |
| - while self._pid and self._executive.check_running_pid(self._pid): |
| - # TODO(burnik): Figure out a cleaner way of stopping wptserve. |
| - if self._platform.is_win(): |
| - self._executive.kill_process(self._pid) |
| - else: |
| - self._executive.interrupt(self._pid) |
| - |
| - # According to Popen.wait(), this can deadlock when using stdout=PIPE and/or stderr=PIPE. |
| - # We're using DEVNULL for both so that should not occur. |
| - if self._process is not None: |
| - self._process.wait() |
| - |
| - # Clean up the pid file. |
| - if self._filesystem.exists(self._pid_file): |
| - self._filesystem.remove(self._pid_file) |