Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1216)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/servers/server_base.py

Issue 2624093003: Remove the overridden _stop_running_server method in WPTServe. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/servers/server_base.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/servers/server_base.py b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/servers/server_base.py
index 5dad347154f4f7eb6c12710c8a3e672b306db66c..6ab1437520f92ef0fec897a562fa67ea26f5f677 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/servers/server_base.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/servers/server_base.py
@@ -32,7 +32,6 @@ import errno
import logging
import socket
import tempfile
-import time
_log = logging.getLogger(__name__)
@@ -231,12 +230,12 @@ class ServerBase(object):
"""Repeat the action for wait_sec or until it succeeds, sleeping for sleep_secs
in between each attempt. Returns whether it succeeded.
"""
- start_time = time.time()
- while time.time() - start_time < wait_secs:
+ start_time = self._port_obj.host.time()
+ while self._port_obj.host.time() - start_time < wait_secs:
if action():
return True
_log.debug("Waiting for action: %s", action)
- time.sleep(sleep_secs)
+ self._port_obj.host.sleep(sleep_secs)
return False

Powered by Google App Engine
This is Rietveld 408576698