MacViews: Correctly handle character events when there's an active TextInputClient.

ui/views/cocoa/bridged_content_view.h

Index: ui/views/cocoa/bridged_content_view.h
diff --git a/ui/views/cocoa/bridged_content_view.h b/ui/views/cocoa/bridged_content_view.h
index f6952a25e80dd9c7a712cc9e24458632e715e6c1..82094ffe440253fab8f562aa46b3ce610ab310c3 100644
--- a/ui/views/cocoa/bridged_content_view.h
+++ b/ui/views/cocoa/bridged_content_view.h
@@ -39,6 +39,10 @@ class View;
   // The keyDown event currently being handled, nil otherwise.
   NSEvent* keyDownEvent_;
 
+  // Has the current |keyDownEvent_| been handled. Only valid when
+  // |keyDownEvent_| is non-nil;
+  BOOL isKeyDownEventHandled_;

[tapted, 2017/01/13 20:02:44]

This will be initialized to NO, so if something calls
handleUnhandledKeyDownAsKeyEvent before the first call to keyDown, then I think
we may try to make a ui::KeyEvent from nil.

Perhaps 

BOOL hasPendingKeyDownEvent_;

(and flip a bunch of logic).

[karandeepb, 2017/01/16 02:02:22]

Makes sense. Though I think hasUnhandledKeyDownEvent_ is better and more
consistent with other code.

+
   // The last tooltip text, used to limit updates.
   base::string16 lastTooltipText_;