MacViews: Correctly handle character events when there's an active TextInputClient.

ui/views/cocoa/bridged_content_view.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_VIEWS_COCOA_BRIDGED_CONTENT_VIEW_H_
 #define UI_VIEWS_COCOA_BRIDGED_CONTENT_VIEW_H_
 
 #import <Cocoa/Cocoa.h>
 
 #include "base/strings/string16.h"
@@ skipping 21 matching lines @@
   // Weak. If non-null the TextInputClient of the currently focused View in the
   // hierarchy rooted at |hostedView_|. Owned by the focused View.
   ui::TextInputClient* textInputClient_;
 
   // A tracking area installed to enable mouseMoved events.
   ui::ScopedCrTrackingArea cursorTrackingArea_;
 
   // The keyDown event currently being handled, nil otherwise.
   NSEvent* keyDownEvent_;
 
+  // Has the current |keyDownEvent_| been handled. Only valid when
+  // |keyDownEvent_| is non-nil;
+  BOOL isKeyDownEventHandled_;

[tapted, 2017/01/13 20:02:44]

This will be initialized to NO, so if something calls
handleUnhandledKeyDownAsKeyEvent before the first call to keyDown, then I think
we may try to make a ui::KeyEvent from nil.

Perhaps 

BOOL hasPendingKeyDownEvent_;

(and flip a bunch of logic).

[karandeepb, 2017/01/16 02:02:22]

Makes sense. Though I think hasUnhandledKeyDownEvent_ is better and more
consistent with other code.

+
   // The last tooltip text, used to limit updates.
   base::string16 lastTooltipText_;
 
   // Whether to draw an almost-transparent background with rounded corners so
   // that OSX correctly blurs the background showing through.
   BOOL drawMenuBackgroundForBlur_;
 
   // Whether dragging on the view moves the window.
   BOOL mouseDownCanMoveWindow_;
 
@@ skipping 28 matching lines @@
 // Update windowMask_ depending on the current view bounds.
 - (void)updateWindowMask;
 
 // Notifies the associated FocusManager whether full keyboard access is enabled
 // or not.
 - (void)updateFullKeyboardAccess;
 
 @end
 
 #endif  // UI_VIEWS_COCOA_BRIDGED_CONTENT_VIEW_H_