Chromium Code Reviews| Index: third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp |
| diff --git a/third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp b/third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp |
| index b49db8f4544d9fcc501eebe93b9c73c89e957656..5a1ee25c2ecacdc5c8587e0e2d2cc450008f885e 100644 |
| --- a/third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp |
| +++ b/third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp |
| @@ -392,9 +392,10 @@ void V8Initializer::initializeMainThread() { |
| gin::IsolateHolder::Initialize(gin::IsolateHolder::kNonStrictMode, |
| v8ExtrasMode, &arrayBufferAllocator); |
| + // NOTE: Some threads don't have a scheduler. |
|
haraken
2017/01/10 23:56:58
Clarify what the threads are.
Ken Rockot(use gerrit already)
2017/01/11 00:22:39
done
|
| WebScheduler* scheduler = Platform::current()->currentThread()->scheduler(); |
| - v8::Isolate* isolate = |
| - V8PerIsolateData::initialize(scheduler->timerTaskRunner()); |
| + v8::Isolate* isolate = V8PerIsolateData::initialize( |
| + scheduler ? scheduler->timerTaskRunner() : nullptr); |
|
haraken
2017/01/10 23:56:58
I'd prefer passing Platform::current()->currentThr
Ken Rockot(use gerrit already)
2017/01/11 00:22:39
done (getWebTaskRunner)
|
| initializeV8Common(isolate); |