Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 2623993006: [ARM] Add vmin, vmax NEON instructions. (Closed)

Created:
3 years, 11 months ago by bbudge
Modified:
3 years, 11 months ago
Reviewers:
martyn.capewell
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[ARM] Add vmin, vmax NEON instructions. - Adds vmin, vmax for FP and integer vectors, both signed and unsigned. - Regularizes switching logic in disasm and simulator for special codes 4 and 6. - Factors vrecpe, vrsqrte, vrecps, vrsqrts into helper fns. LOG=N BUG=v8:4124 Review-Url: https://codereview.chromium.org/2623993006 Cr-Commit-Position: refs/heads/master@{#42385} Committed: https://chromium.googlesource.com/v8/v8/+/a7e67924d1e52c649a5f4debba3232f2fd9af439

Patch Set 1 #

Patch Set 2 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+336 lines, -56 lines) Patch
M src/arm/assembler-arm.h View 1 chunk +8 lines, -0 lines 0 comments Download
M src/arm/assembler-arm.cc View 1 chunk +87 lines, -27 lines 0 comments Download
M src/arm/disasm-arm.cc View 7 chunks +39 lines, -12 lines 0 comments Download
M src/arm/simulator-arm.cc View 9 chunks +132 lines, -16 lines 0 comments Download
M test/cctest/test-assembler-arm.cc View 1 7 chunks +60 lines, -1 line 0 comments Download
M test/cctest/test-disasm-arm.cc View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
bbudge
3 years, 11 months ago (2017-01-12 22:25:42 UTC) #6
martyn.capewell
lgtm
3 years, 11 months ago (2017-01-16 15:51:23 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2623993006/20001
3 years, 11 months ago (2017-01-16 19:10:12 UTC) #11
commit-bot: I haz the power
3 years, 11 months ago (2017-01-16 19:36:32 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/a7e67924d1e52c649a5f4debba3232f2fd9...

Powered by Google App Engine
This is Rietveld 408576698