Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Unified Diff: chrome/browser/resources/settings/people_page/change_picture.js

Issue 2623993002: MD Settings People: Fix ChromeOS Change Picture arrow keys (Closed)
Patch Set: Merge branch 'master' of https://chromium.googlesource.com/chromium/src into 366-settings-fix-chang… Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/test/data/webui/settings/people_page_change_picture_test.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/settings/people_page/change_picture.js
diff --git a/chrome/browser/resources/settings/people_page/change_picture.js b/chrome/browser/resources/settings/people_page/change_picture.js
index 6ea1eb945024f90d2db5837c94b6007b38adbc76..9cad7f25da1c5c9b67f5f8d65f183bd36cff8ee0 100644
--- a/chrome/browser/resources/settings/people_page/change_picture.js
+++ b/chrome/browser/resources/settings/people_page/change_picture.js
@@ -282,6 +282,9 @@ Polymer({
selector.selectPrevious();
} while (this.selectedItem_.hidden);
+ if (this.selectedItem_.dataset.type != ChangePictureSelectionTypes.FILE)
+ this.selectImage_(this.selectedItem_);
+
this.lastSelectedImageType_ = this.selectedItem_.dataset.type;
e.detail.keyboardEvent.preventDefault();
break;
@@ -294,6 +297,9 @@ Polymer({
selector.selectNext();
} while (this.selectedItem_.hidden);
+ if (this.selectedItem_.dataset.type != ChangePictureSelectionTypes.FILE)
+ this.selectImage_(this.selectedItem_);
+
this.lastSelectedImageType_ = this.selectedItem_.dataset.type;
e.detail.keyboardEvent.preventDefault();
break;
« no previous file with comments | « no previous file | chrome/test/data/webui/settings/people_page_change_picture_test.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698