Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(594)

Issue 2623963002: ozone: Allocate scanout buffers according to KMS modifiers. (Closed)

Created:
3 years, 11 months ago by Daniele Castagna
Modified:
3 years, 11 months ago
Reviewers:
marcheu, dnicoara, hoegsberg
CC:
chromium-reviews, kalyank, ozone-reviews_chromium.org, piman+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ozone: Allocate scanout buffers according to KMS modifiers. KMS now advertises per plane buffer modifiers. This patch uses that information to make an educated choice on which modifiers to use when allocating scanout buffers for a specific crtcs. patch from issue 2576263002 at patchset 60001 (http://crrev.com/2576263002#ps60001) BUG=chrome-os-partner:56407 Review-Url: https://codereview.chromium.org/2623963002 Cr-Commit-Position: refs/heads/master@{#442979} Committed: https://chromium.googlesource.com/chromium/src/+/f7f9a427b0d22429efb3cb62ff7d4f55f6f5176f

Patch Set 1 #

Patch Set 2 : Make ozone_unittests compile. #

Patch Set 3 : Remove unused modifier_. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+215 lines, -30 lines) Patch
M ui/ozone/platform/drm/gpu/crtc_controller.h View 1 chunk +10 lines, -0 lines 0 comments Download
M ui/ozone/platform/drm/gpu/crtc_controller.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/ozone/platform/drm/gpu/drm_buffer.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ui/ozone/platform/drm/gpu/drm_device.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/ozone/platform/drm/gpu/drm_device.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M ui/ozone/platform/drm/gpu/drm_thread.cc View 1 chunk +15 lines, -2 lines 0 comments Download
M ui/ozone/platform/drm/gpu/gbm_buffer.h View 1 2 2 chunks +18 lines, -1 line 0 comments Download
M ui/ozone/platform/drm/gpu/gbm_buffer.cc View 1 2 5 chunks +47 lines, -12 lines 0 comments Download
M ui/ozone/platform/drm/gpu/gbm_buffer_base.h View 1 chunk +3 lines, -1 line 0 comments Download
M ui/ozone/platform/drm/gpu/gbm_buffer_base.cc View 2 chunks +11 lines, -2 lines 0 comments Download
M ui/ozone/platform/drm/gpu/hardware_display_controller.h View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/ozone/platform/drm/gpu/hardware_display_controller.cc View 1 chunk +22 lines, -0 lines 0 comments Download
M ui/ozone/platform/drm/gpu/hardware_display_plane.h View 3 chunks +6 lines, -0 lines 0 comments Download
M ui/ozone/platform/drm/gpu/hardware_display_plane.cc View 3 chunks +25 lines, -4 lines 0 comments Download
M ui/ozone/platform/drm/gpu/hardware_display_plane_manager.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/ozone/platform/drm/gpu/hardware_display_plane_manager.cc View 5 chunks +32 lines, -3 lines 0 comments Download
M ui/ozone/platform/drm/gpu/mock_drm_device.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/ozone/platform/drm/gpu/mock_drm_device.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/ozone/platform/drm/gpu/mock_hardware_display_plane_manager.cc View 1 3 chunks +7 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (13 generated)
Daniele Castagna
PTAL.
3 years, 11 months ago (2017-01-11 04:55:00 UTC) #10
dnicoara
lgtm
3 years, 11 months ago (2017-01-11 15:01:09 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2623963002/40001
3 years, 11 months ago (2017-01-11 19:16:45 UTC) #14
commit-bot: I haz the power
3 years, 11 months ago (2017-01-11 19:30:32 UTC) #17
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/f7f9a427b0d22429efb3cb62ff7d...

Powered by Google App Engine
This is Rietveld 408576698