Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issue 2623943002: Scroll the position into view when the content is not visible. (Closed)

Created:
3 years, 11 months ago by bokan
Modified:
3 years, 11 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

Scroll the position into view when the content is not visible. Previously, we implement scrollIntoView by scrolling the intersection of the viewport and the content. However, when the content is not visible in the viewport, e.g. outside boundary and the viewport's overflow attribute is hidden, the intersection would be empty and the browser would stop the scrolling logic. In this case, we presume the webpage wants to scroll the position of the content but for some reason doesn't want to show it. In this patch, we scroll the content's position for this special case. BUG=673396 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2576963002 Cr-Commit-Position: refs/heads/master@{#441469} (cherry picked from commit 961e2d024412588edffbef5b3f6dfdfd2646761f) Review-Url: https://codereview.chromium.org/2623943002 . Cr-Commit-Position: refs/branch-heads/2924@{#721} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} Committed: https://chromium.googlesource.com/chromium/src/+/5b721546a2fda3b3b822c09af0c1ecfd783a5fcc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -16 lines) Patch
A third_party/WebKit/LayoutTests/fast/scrolling/scroll-into-view-hidden-element.html View 1 chunk +15 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp View 2 chunks +14 lines, -16 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
bokan
3 years, 11 months ago (2017-01-10 20:22:32 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5b721546a2fda3b3b822c09af0c1ecfd783a5fcc.

Powered by Google App Engine
This is Rietveld 408576698