Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(526)

Issue 2623843002: [foozzie] Add correctness fuzzer resources to build output (Closed)

Created:
3 years, 11 months ago by Michael Achenbach
Modified:
3 years, 11 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[foozzie] Add correctness fuzzer resources to build output This adds the correctness fuzzer harness files to the output directory guarded by a gn arg. The switch will be turned on on the builder uploading builds to clusterfuzz. BUG=chromium:673246 NOTRY=true TBR=tandrii@chromium.org,jochen@chromium.org Review-Url: https://codereview.chromium.org/2623843002 Cr-Commit-Position: refs/heads/master@{#42166} Committed: https://chromium.googlesource.com/v8/v8/+/0bdb4690078a67d91f30454c1b438185a93d9aa6

Patch Set 1 #

Total comments: 2

Patch Set 2 : Review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -0 lines) Patch
M BUILD.gn View 1 1 chunk +4 lines, -0 lines 0 comments Download
M gni/v8.gni View 1 chunk +3 lines, -0 lines 0 comments Download
A tools/foozzie/BUILD.gn View 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (11 generated)
Michael Achenbach
PTAL
3 years, 11 months ago (2017-01-10 08:53:14 UTC) #3
jochen (gone - plz use gerrit)
lgtm
3 years, 11 months ago (2017-01-10 09:45:03 UTC) #9
kjellander_chromium
lgtm with nit https://codereview.chromium.org/2623843002/diff/1/BUILD.gn File BUILD.gn (right): https://codereview.chromium.org/2623843002/diff/1/BUILD.gn#newcode2584 BUILD.gn:2584: deps += [ "tools/foozzie/:v8_correctness_fuzzer_resources" ] This ...
3 years, 11 months ago (2017-01-10 10:06:31 UTC) #10
Michael Achenbach
https://codereview.chromium.org/2623843002/diff/1/BUILD.gn File BUILD.gn (right): https://codereview.chromium.org/2623843002/diff/1/BUILD.gn#newcode2584 BUILD.gn:2584: deps += [ "tools/foozzie/:v8_correctness_fuzzer_resources" ] On 2017/01/10 10:06:31, kjellander_chromium ...
3 years, 11 months ago (2017-01-10 10:17:35 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2623843002/20001
3 years, 11 months ago (2017-01-10 10:17:41 UTC) #14
commit-bot: I haz the power
3 years, 11 months ago (2017-01-10 10:19:25 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/0bdb4690078a67d91f30454c1b438185a93...

Powered by Google App Engine
This is Rietveld 408576698