Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(441)

Issue 2623833005: Revert of Make extensions DSE persistent in browser prefs (Closed)

Created:
3 years, 11 months ago by foolip
Modified:
3 years, 11 months ago
CC:
Bernhard Bauer, chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Make extensions DSE persistent in browser prefs (patchset #15 id:280001 of https://codereview.chromium.org/2479113002/ ) Reason for revert: ExtensionBrowserTest.OverrideHomePageSettings and ExtensionBrowserTest.OverrideStartupPagesSettings are flaky. BUG=679470, 679569 Original issue's description: > Make extensions DSE persistent in browser prefs > > This fix stores extension installed DSE in browser prefs using extension > overriden preferences API. This is needed so extension installed default > search would be available from browser before extensions subsystem load. > This will affect url for first loaded NTP which is taken from current > default search settings. > > BUG=450534 > > R=pkasting@chromium.org, vasilii@chromium.org > > Review-Url: https://codereview.chromium.org/2479113002 > Cr-Commit-Position: refs/heads/master@{#442235} > Committed: https://chromium.googlesource.com/chromium/src/+/f5f1407adee2b18b59b33fb8d74739dcc27d8c0b TBR=gab@chromium.org,hashimoto@chromium.org,maxbogue@chromium.org,pkasting@chromium.org,vasilii@chromium.org,a-v-y@yandex-team.ru # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=450534 Review-Url: https://codereview.chromium.org/2623833005 Cr-Commit-Position: refs/heads/master@{#442612} Committed: https://chromium.googlesource.com/chromium/src/+/8534d16a27bc5999a28c0d964e1a5b5409617b39

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+325 lines, -565 lines) Patch
M chrome/browser/extensions/api/settings_overrides/settings_overrides_api.h View 4 chunks +15 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/settings_overrides/settings_overrides_api.cc View 9 chunks +67 lines, -35 lines 0 comments Download
M chrome/browser/extensions/api/settings_overrides/settings_overrides_browsertest.cc View 2 chunks +80 lines, -140 lines 0 comments Download
M chrome/browser/prefs/session_startup_pref.h View 1 chunk +4 lines, -6 lines 0 comments Download
M chrome/browser/search_engines/template_url_service_sync_unittest.cc View 4 chunks +1 line, -106 lines 0 comments Download
M chrome/browser/search_engines/template_url_service_test_util.h View 2 chunks +0 lines, -13 lines 0 comments Download
M chrome/browser/search_engines/template_url_service_test_util.cc View 2 chunks +0 lines, -26 lines 0 comments Download
M chrome/browser/search_engines/template_url_service_unittest.cc View 5 chunks +12 lines, -46 lines 0 comments Download
M components/search_engines/BUILD.gn View 2 chunks +0 lines, -3 lines 0 comments Download
M components/search_engines/default_search_manager.h View 1 chunk +8 lines, -0 lines 0 comments Download
M components/search_engines/default_search_manager.cc View 6 chunks +23 lines, -13 lines 0 comments Download
M components/search_engines/default_search_manager_unittest.cc View 6 chunks +56 lines, -17 lines 0 comments Download
D components/search_engines/search_engines_test_util.h View 1 chunk +0 lines, -38 lines 0 comments Download
D components/search_engines/search_engines_test_util.cc View 1 chunk +0 lines, -77 lines 0 comments Download
M components/search_engines/template_url.h View 3 chunks +4 lines, -10 lines 0 comments Download
M components/search_engines/template_url.cc View 2 chunks +16 lines, -13 lines 0 comments Download
M components/search_engines/template_url_prepopulate_data.h View 1 chunk +0 lines, -4 lines 0 comments Download
M components/search_engines/template_url_prepopulate_data.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M components/search_engines/template_url_service.h View 1 chunk +7 lines, -0 lines 0 comments Download
M components/search_engines/template_url_service.cc View 4 chunks +32 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
foolip
Created Revert of Make extensions DSE persistent in browser prefs
3 years, 11 months ago (2017-01-10 15:40:56 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2623833005/1
3 years, 11 months ago (2017-01-10 15:41:17 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/8534d16a27bc5999a28c0d964e1a5b5409617b39
3 years, 11 months ago (2017-01-10 16:51:37 UTC) #6
stevenjb
On 2017/01/10 16:51:37, commit-bot: I haz the power wrote: > Committed patchset #1 (id:1) as ...
3 years, 11 months ago (2017-01-20 23:28:10 UTC) #7
stevenjb
3 years, 11 months ago (2017-01-20 23:28:32 UTC) #8
Message was sent while issue was closed.
On 2017/01/20 23:28:10, stevenjb wrote:
> On 2017/01/10 16:51:37, commit-bot: I haz the power wrote:
> > Committed patchset #1 (id:1) as
> >
>
https://chromium.googlesource.com/chromium/src/+/8534d16a27bc5999a28c0d964e1a...
> 
> Note: The reverted CL was also the cause of crbug.com/680197

(Oops, wrong CL, please ignore)

Powered by Google App Engine
This is Rietveld 408576698