third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp - Issue 2623823002: Rename and change parameter type of some GeometryMapper methods

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp

Issue 2623823002: Rename and change parameter type of some GeometryMapper methods (Closed)

Patch Set: Swap local and ancestor parameters in ancestorToLocalRect(). Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/paint/PaintLayerClipper.cpp ('k') | third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.cpp » ('j') | third_party/WebKit/Source/platform/graphics/paint/GeometryMapper.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp

diff --git a/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp b/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp

index 76339c18e9f23969b9a83b58501c3c737cf9be1a..195f5a9b6c1b9f40696a6e092a5554d94ed17a0b 100644

--- a/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp

+++ b/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp

@@ -80,7 +80,7 @@ void PaintPropertyTreeBuilderTest::TearDown() {

auto contentsProperties = \

(ancestorLayoutObject)->paintProperties()->contentsProperties(); \

LayoutRect actual = \

- LayoutRect(geometryMapper.mapToVisualRectInDestinationSpace( \

+ LayoutRect(geometryMapper.sourceToDestinationVisualRect( \

FloatRect(source), *(sourceLayoutObject) \

->paintProperties() \

->localBorderBoxProperties(), \