Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Unified Diff: third_party/WebKit/Source/core/paint/PaintInvalidator.cpp

Issue 2623823002: Rename and change parameter type of some GeometryMapper methods (Closed)
Patch Set: Swap local and ancestor parameters in ancestorToLocalRect(). Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/paint/PaintInvalidator.cpp
diff --git a/third_party/WebKit/Source/core/paint/PaintInvalidator.cpp b/third_party/WebKit/Source/core/paint/PaintInvalidator.cpp
index cd44b829262c913ced298c5ab98875deb1a9a90f..b8ff7389fdf6b067bf97ed7089e0906fa4efa0a2 100644
--- a/third_party/WebKit/Source/core/paint/PaintInvalidator.cpp
+++ b/third_party/WebKit/Source/core/paint/PaintInvalidator.cpp
@@ -110,7 +110,7 @@ static LayoutRect mapLocalRectToPaintInvalidationBacking(
containerPaintProperties->contentsProperties();
bool success = false;
- result = LayoutRect(geometryMapper.mapToVisualRectInDestinationSpace(
+ result = LayoutRect(geometryMapper.sourceToDestinationVisualRect(
rect, currentTreeState, containerContentsProperties, success));
DCHECK(success);
@@ -166,11 +166,6 @@ LayoutPoint PaintInvalidator::computeLocationInBacking(
if (object != context.paintInvalidationContainer) {
point.moveBy(FloatPoint(object.paintOffset()));
- PropertyTreeState currentTreeState(
- context.treeBuilderContext.current.transform,
- context.treeBuilderContext.current.clip,
- context.treeBuilderContext.currentEffect,
- context.treeBuilderContext.current.scroll);
const auto* containerPaintProperties =
context.paintInvalidationContainer->paintProperties();
auto containerContentsProperties =
@@ -178,9 +173,10 @@ LayoutPoint PaintInvalidator::computeLocationInBacking(
bool success = false;
point = m_geometryMapper
- .mapRectToDestinationSpace(FloatRect(point, FloatSize()),
- currentTreeState,
- containerContentsProperties, success)
+ .sourceToDestinationRect(
+ FloatRect(point, FloatSize()),
+ context.treeBuilderContext.current.transform,
+ containerContentsProperties.transform(), success)
.location();
DCHECK(success);

Powered by Google App Engine
This is Rietveld 408576698