[wasm] Introduce WasmToInterpreterFrame

[wasm] Introduce WasmToInterpreterFrame

and rename WasmFrame to WasmCompiledFrame.
The WasmToInterpreterFrames are not used yet; this will follow in a
follow-up CL (see tracking bug for the overall picture).
Those frames will represent frames for WASM_TO_INTERPRETER stubs, which
call from wasm code to the wasm interpreter, implemented in C++.
They will support the Summarize method to inspect the stack frames in
the wasm interpreter.

R=yangguo@chromium.org, titzer@chromium.org
BUG=v8:5822
Review-Url: https://codereview.chromium.org/2623773004
Cr-Commit-Position: refs/heads/master@{#42213}
Committed: https://chromium.googlesource.com/v8/v8/+/81700ddfdc579c54e03d4d26fc0331fc13f92aca

[Clemens Hammacher, 2017-01-10 10:48:55]

The CQ bit was checked by clemensh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-10 10:48:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-10 10:53:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-10 10:53:15]

Dry run: Try jobs failed on following builders:
  v8_mac_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/15245)
  v8_win_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel_ng/builds/20522)

[Clemens Hammacher, 2017-01-10 10:58:29]

The CQ bit was checked by clemensh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-10 10:58:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-10 11:35:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-10 11:35:46]

Dry run: This issue passed the CQ dry run.

[titzer, 2017-01-10 18:54:56]

lgtm modulo naming

https://codereview.chromium.org/2623773004/diff/20001/src/frames.h
File src/frames.h (right):

https://codereview.chromium.org/2623773004/diff/20001/src/frames.h#newcode103
src/frames.h:103: V(WASM_TO_INTERPRETER, WasmToInterpreterFrame)         \
Can we name this WASM_INTERPRETER_ENTRY?

https://codereview.chromium.org/2623773004/diff/20001/src/frames.h#newcode470
src/frames.h:470: bool is_wasm_to_interpreter() const { return type() ==
WASM_TO_INTERPRETER; }
same here.

[Clemens Hammacher, 2017-01-11 08:30:50]

The CQ bit was checked by clemensh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-11 08:30:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Clemens Hammacher, 2017-01-11 08:39:15]

https://codereview.chromium.org/2623773004/diff/20001/src/frames.h
File src/frames.h (right):

https://codereview.chromium.org/2623773004/diff/20001/src/frames.h#newcode103
src/frames.h:103: V(WASM_TO_INTERPRETER, WasmToInterpreterFrame)         \
On 2017/01/10 at 18:54:56, titzer wrote:
> Can we name this WASM_INTERPRETER_ENTRY?

Renamed
- Code::WASM_TO_INTERPRETER to Code::WASM_INTERPRETER_ENTRY
- StackFrame::WASM_TO_INTERPRETER to StackFrame::WASM_INTERPRETER_ENTRY
- WasmToInterpreterFrame to WasmInterpreterEntryFrame.

https://codereview.chromium.org/2623773004/diff/20001/src/frames.h#newcode470
src/frames.h:470: bool is_wasm_to_interpreter() const { return type() ==
WASM_TO_INTERPRETER; }
On 2017/01/10 at 18:54:56, titzer wrote:
> same here.

Done.

[commit-bot: I haz the power, 2017-01-11 09:01:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-11 09:01:07]

Dry run: This issue passed the CQ dry run.

[Yang, 2017-01-11 10:13:14]

On 2017/01/11 08:39:15, Clemens Hammacher wrote:
> https://codereview.chromium.org/2623773004/diff/20001/src/frames.h
> File src/frames.h (right):
> 
> https://codereview.chromium.org/2623773004/diff/20001/src/frames.h#newcode103
> src/frames.h:103: V(WASM_TO_INTERPRETER, WasmToInterpreterFrame)         \
> On 2017/01/10 at 18:54:56, titzer wrote:
> > Can we name this WASM_INTERPRETER_ENTRY?
> 
> Renamed
> - Code::WASM_TO_INTERPRETER to Code::WASM_INTERPRETER_ENTRY
> - StackFrame::WASM_TO_INTERPRETER to StackFrame::WASM_INTERPRETER_ENTRY
> - WasmToInterpreterFrame to WasmInterpreterEntryFrame.
> 
> https://codereview.chromium.org/2623773004/diff/20001/src/frames.h#newcode470
> src/frames.h:470: bool is_wasm_to_interpreter() const { return type() ==
> WASM_TO_INTERPRETER; }
> On 2017/01/10 at 18:54:56, titzer wrote:
> > same here.
> 
> Done.

lgtm.

[Clemens Hammacher, 2017-01-11 10:14:08]

The CQ bit was checked by clemensh@chromium.org

[Clemens Hammacher, 2017-01-11 10:14:08]

The patchset sent to the CQ was uploaded after l-g-t-m from titzer@chromium.org
Link to the patchset: https://codereview.chromium.org/2623773004/#ps40001
(title: "Renaming")

[commit-bot: I haz the power, 2017-01-11 10:14:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 10:16:11]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1484129648486950,
"parent_rev": "7ef86f809131b169223b0cfe4a2b93792142da4a", "commit_rev":
"81700ddfdc579c54e03d4d26fc0331fc13f92aca"}

[commit-bot: I haz the power, 2017-01-11 10:16:19]

Description was changed from

==========
[wasm] Introduce WasmToInterpreterFrame

and rename WasmFrame to WasmCompiledFrame.
The WasmToInterpreterFrames are not used yet; this will follow in a
follow-up CL (see tracking bug for the overall picture).
Those frames will represent frames for WASM_TO_INTERPRETER stubs, which
call from wasm code to the wasm interpreter, implemented in C++.
They will support the Summarize method to inspect the stack frames in
the wasm interpreter.

R=yangguo@chromium.org, titzer@chromium.org
BUG=v8:5822
==========

to

==========
[wasm] Introduce WasmToInterpreterFrame

and rename WasmFrame to WasmCompiledFrame.
The WasmToInterpreterFrames are not used yet; this will follow in a
follow-up CL (see tracking bug for the overall picture).
Those frames will represent frames for WASM_TO_INTERPRETER stubs, which
call from wasm code to the wasm interpreter, implemented in C++.
They will support the Summarize method to inspect the stack frames in
the wasm interpreter.

R=yangguo@chromium.org, titzer@chromium.org
BUG=v8:5822

Review-Url: https://codereview.chromium.org/2623773004
Cr-Commit-Position: refs/heads/master@{#42213}
Committed:
https://chromium.googlesource.com/v8/v8/+/81700ddfdc579c54e03d4d26fc0331fc13f...
==========

[commit-bot: I haz the power, 2017-01-11 10:16:19]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/81700ddfdc579c54e03d4d26fc0331fc13f...