Split out ChildWindowWin

Split out ChildWindowWin

This will allow other GL Surface implementations than
ChildWindowSurfaceWin to create a child window on a new thread.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2623763003
Cr-Commit-Position: refs/heads/master@{#442749}
Committed: https://chromium.googlesource.com/chromium/src/+/267fd834f5c7c9d1e65b0a391a169bc689ba4a85

[jbauman, 2017-01-10 02:42:21]

Description was changed from

==========
Split out ChildWindowWin

This will allow other GL Surface implementations than
ChildWindowSurfaceWin to create a child window on a new thread.
==========

to

==========
Split out ChildWindowWin

This will allow other GL Surface implementations than
ChildWindowSurfaceWin to create a child window on a new thread.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[jbauman, 2017-01-10 02:42:27]

The CQ bit was checked by jbauman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-10 02:43:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-10 05:59:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-10 05:59:01]

Dry run: This issue passed the CQ dry run.

[jbauman, 2017-01-10 19:35:04]

The CQ bit was checked by jbauman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-10 19:36:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jbauman, 2017-01-10 20:00:42]

jbauman@chromium.org changed reviewers:
+ stanisc@chromium.org

[stanisc, 2017-01-10 20:54:57]

LGTM with a couple of nits.

https://codereview.chromium.org/2623763003/diff/20001/gpu/ipc/service/child_w...
File gpu/ipc/service/child_window_surface_win.cc (right):

https://codereview.chromium.org/2623763003/diff/20001/gpu/ipc/service/child_w...
gpu/ipc/service/child_window_surface_win.cc:69: window_ =
child_window_.window();
Could you just use child_window_.window() instead of window_ in the rest of the
code?

https://codereview.chromium.org/2623763003/diff/20001/gpu/ipc/service/child_w...
File gpu/ipc/service/child_window_win.h (right):

https://codereview.chromium.org/2623763003/diff/20001/gpu/ipc/service/child_w...
gpu/ipc/service/child_window_win.h:17: class ChildWindowWin {
Consider adding a short comment that explaining the class purpose.

[jbauman, 2017-01-10 21:12:42]

On 2017/01/10 20:54:57, stanisc wrote:
> LGTM with a couple of nits.
> 
>
https://codereview.chromium.org/2623763003/diff/20001/gpu/ipc/service/child_w...
> File gpu/ipc/service/child_window_surface_win.cc (right):
> 
>
https://codereview.chromium.org/2623763003/diff/20001/gpu/ipc/service/child_w...
> gpu/ipc/service/child_window_surface_win.cc:69: window_ =
> child_window_.window();
> Could you just use child_window_.window() instead of window_ in the rest of
the
> code?

No, window_ is from the parent class and is used for other things there.
> 
>
https://codereview.chromium.org/2623763003/diff/20001/gpu/ipc/service/child_w...
> File gpu/ipc/service/child_window_win.h (right):
> 
>
https://codereview.chromium.org/2623763003/diff/20001/gpu/ipc/service/child_w...
> gpu/ipc/service/child_window_win.h:17: class ChildWindowWin {
> Consider adding a short comment that explaining the class purpose.

Will do.

[commit-bot: I haz the power, 2017-01-10 21:45:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-10 21:45:40]

Dry run: This issue passed the CQ dry run.

[jbauman, 2017-01-10 22:32:55]

The CQ bit was checked by jbauman@chromium.org

[jbauman, 2017-01-10 22:32:56]

The patchset sent to the CQ was uploaded after l-g-t-m from stanisc@chromium.org
Link to the patchset: https://codereview.chromium.org/2623763003/#ps40001
(title: "add comment")

[commit-bot: I haz the power, 2017-01-10 22:33:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 01:00:11]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1484087575775040,
"parent_rev": "1d1bf1cbc6c47fe45e286c84998f1ebf517d8946", "commit_rev":
"267fd834f5c7c9d1e65b0a391a169bc689ba4a85"}

[commit-bot: I haz the power, 2017-01-11 01:00:39]

Description was changed from

==========
Split out ChildWindowWin

This will allow other GL Surface implementations than
ChildWindowSurfaceWin to create a child window on a new thread.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Split out ChildWindowWin

This will allow other GL Surface implementations than
ChildWindowSurfaceWin to create a child window on a new thread.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2623763003
Cr-Commit-Position: refs/heads/master@{#442749}
Committed:
https://chromium.googlesource.com/chromium/src/+/267fd834f5c7c9d1e65b0a391a16...
==========

[commit-bot: I haz the power, 2017-01-11 01:00:40]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/267fd834f5c7c9d1e65b0a391a16...