Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(390)

Issue 2623753003: Disable no-compile tests when cross-compiling (Closed)

Created:
3 years, 11 months ago by wychen
Modified:
3 years, 11 months ago
Reviewers:
lmilko, Nico
CC:
chromium-reviews, dcheng
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable no-compile tests when cross-compiling BUG=679699 Review-Url: https://codereview.chromium.org/2623753003 Cr-Commit-Position: refs/heads/master@{#442592} Committed: https://chromium.googlesource.com/chromium/src/+/1e7c9add546d108518e9128cb9cd24b873f5afd4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/nocompile.gni View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (4 generated)
wychen
PTAL
3 years, 11 months ago (2017-01-10 11:22:02 UTC) #2
lmilko
With skipping no-compile tests, cross-compiling is working for MIPS Linux and ARM Linux. lgtm
3 years, 11 months ago (2017-01-10 11:51:37 UTC) #3
Nico
3 years, 11 months ago (2017-01-10 12:50:31 UTC) #4
wychen
On 2017/01/10 12:50:31, Nico wrote: The last message was empty.
3 years, 11 months ago (2017-01-10 13:09:20 UTC) #5
Nico
lgtm
3 years, 11 months ago (2017-01-10 14:13:10 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2623753003/1
3 years, 11 months ago (2017-01-10 14:25:11 UTC) #8
wychen
On 2017/01/10 14:13:10, Nico wrote: > lgtm Thank you for your prompt review!
3 years, 11 months ago (2017-01-10 14:25:15 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-10 15:39:32 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1e7c9add546d108518e9128cb9cd...

Powered by Google App Engine
This is Rietveld 408576698