Native themes: Add separator color

Native themes:  Add separator color

Previously, separators always used 0xE9E9E9.  This CL allows themes to specify
the color.  This is currently overridden by the Gtk theme which gives a better
appearance on dark themes.  The difference can be seen in:
https://bugs.chromium.org/p/chromium/issues/detail?id=132847#c39

BUG=132847
R=erg@chromium.org,estade@chromium.org,sky@chromium.org

Review-Url: https://codereview.chromium.org/2623753002
Cr-Commit-Position: refs/heads/master@{#442702}
Committed: https://chromium.googlesource.com/chromium/src/+/075738e179fbc566ba99aa8f77737a2b49ee8b97

[Tom (Use chromium acct), 2017-01-10 01:46:31]

Description was changed from

==========
Native themes:  Add separator color

BUG=132847
==========

to

==========
Native themes:  Add separator color

Previously, separators always used 0xE9E9E9.  This CL allows themes to specify
the color.  This is currently overridden by the Gtk theme which gives a better
appearance on dark themes.  The difference can be seen in: 

BUG=132847
==========

[Tom (Use chromium acct), 2017-01-10 01:46:31]

thomasanderson@google.com changed reviewers:
+ erg@chromium.org, estade@chromium.org, sky@chromium.org

[Tom (Use chromium acct), 2017-01-10 01:59:59]

Description was changed from

==========
Native themes:  Add separator color

Previously, separators always used 0xE9E9E9.  This CL allows themes to specify
the color.  This is currently overridden by the Gtk theme which gives a better
appearance on dark themes.  The difference can be seen in: 

BUG=132847
==========

to

==========
Native themes:  Add separator color

Previously, separators always used 0xE9E9E9.  This CL allows themes to specify
the color.  This is currently overridden by the Gtk theme which gives a better
appearance on dark themes.  The difference can be seen in:
https://bugs.chromium.org/p/chromium/issues/detail?id=132847#c39

BUG=132847
R=erg@chromium.org,estade@chromium.org,sky@chromium.org
==========

[Tom (Use chromium acct), 2017-01-10 02:01:11]

reviewers PTAL

erg:
  chrome/browser/ui/libgtkui/native_theme_gtk2.cc
  chrome/browser/ui/libgtkui/native_theme_gtk2.h
  chrome/browser/ui/libgtkui/native_theme_gtk3.cc
estade:
  ui/native_theme/common_theme.cc
  ui/native_theme/native_theme.h
  ui/native_theme/native_theme_dark_aura.cc
sky:
  ui/views/controls/separator.cc
  ui/views/controls/separator.h

[sky, 2017-01-10 15:56:37]

separator LGTM

https://codereview.chromium.org/2623753002/diff/1/ui/views/controls/separator.cc
File ui/views/controls/separator.cc (right):

https://codereview.chromium.org/2623753002/diff/1/ui/views/controls/separator...
ui/views/controls/separator.cc:35: void Separator::SetColorFromNativeTheme() {
Style guide says declaration and definition order should match.

[Evan Stade, 2017-01-10 16:58:07]

lgtm

https://codereview.chromium.org/2623753002/diff/1/ui/views/controls/separator.h
File ui/views/controls/separator.h (right):

https://codereview.chromium.org/2623753002/diff/1/ui/views/controls/separator...
ui/views/controls/separator.h:50: SkColor color_;
if you make this base::Optional<SkColor> you don't need the new member

[Elliot Glaysher, 2017-01-10 18:13:25]

lgtm

[Tom (Use chromium acct), 2017-01-10 20:59:10]

https://codereview.chromium.org/2623753002/diff/1/ui/views/controls/separator.cc
File ui/views/controls/separator.cc (right):

https://codereview.chromium.org/2623753002/diff/1/ui/views/controls/separator...
ui/views/controls/separator.cc:35: void Separator::SetColorFromNativeTheme() {
On 2017/01/10 15:56:37, sky wrote:
> Style guide says declaration and definition order should match.

Done.

https://codereview.chromium.org/2623753002/diff/1/ui/views/controls/separator.h
File ui/views/controls/separator.h (right):

https://codereview.chromium.org/2623753002/diff/1/ui/views/controls/separator...
ui/views/controls/separator.h:50: SkColor color_;
On 2017/01/10 16:58:07, Evan Stade wrote:
> if you make this base::Optional<SkColor> you don't need the new member

But then color() would be more complicated and it would have to be renamed to
GetColor() :(

[Tom (Use chromium acct), 2017-01-10 20:59:15]

The CQ bit was checked by thomasanderson@google.com

[Tom (Use chromium acct), 2017-01-10 20:59:16]

The patchset sent to the CQ was uploaded after l-g-t-m from erg@chromium.org,
sky@chromium.org, estade@chromium.org
Link to the patchset: https://codereview.chromium.org/2623753002/#ps20001
(title: "Change function order")

[commit-bot: I haz the power, 2017-01-10 20:59:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-10 21:54:06]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484081955619370,
"parent_rev": "162f59830c2258bd3bc15ca9442a9d4fbfe96b1d", "commit_rev":
"075738e179fbc566ba99aa8f77737a2b49ee8b97"}

[commit-bot: I haz the power, 2017-01-10 21:54:38]

Description was changed from

==========
Native themes:  Add separator color

Previously, separators always used 0xE9E9E9.  This CL allows themes to specify
the color.  This is currently overridden by the Gtk theme which gives a better
appearance on dark themes.  The difference can be seen in:
https://bugs.chromium.org/p/chromium/issues/detail?id=132847#c39

BUG=132847
R=erg@chromium.org,estade@chromium.org,sky@chromium.org
==========

to

==========
Native themes:  Add separator color

Previously, separators always used 0xE9E9E9.  This CL allows themes to specify
the color.  This is currently overridden by the Gtk theme which gives a better
appearance on dark themes.  The difference can be seen in:
https://bugs.chromium.org/p/chromium/issues/detail?id=132847#c39

BUG=132847
R=erg@chromium.org,estade@chromium.org,sky@chromium.org

Review-Url: https://codereview.chromium.org/2623753002
Cr-Commit-Position: refs/heads/master@{#442702}
Committed:
https://chromium.googlesource.com/chromium/src/+/075738e179fbc566ba99aa8f7773...
==========

[commit-bot: I haz the power, 2017-01-10 21:54:39]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/075738e179fbc566ba99aa8f7773...

[Evan Stade, 2017-01-11 00:32:04]

https://codereview.chromium.org/2623753002/diff/1/ui/views/controls/separator.h
File ui/views/controls/separator.h (right):

https://codereview.chromium.org/2623753002/diff/1/ui/views/controls/separator...
ui/views/controls/separator.h:50: SkColor color_;
On 2017/01/10 20:59:10, Tom Anderson wrote:
> On 2017/01/10 16:58:07, Evan Stade wrote:
> > if you make this base::Optional<SkColor> you don't need the new member
> 
> But then color() would be more complicated and it would have to be renamed to
> GetColor() :(

good thing it's never actually called then