Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(636)

Unified Diff: components/security_interstitials/content/security_interstitial_page.h

Issue 2623733002: Componentize SafeBrowsingBlockingPage for WebView use (Closed)
Patch Set: rebase again + nits Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/security_interstitials/content/security_interstitial_page.h
diff --git a/components/security_interstitials/content/security_interstitial_page.h b/components/security_interstitials/content/security_interstitial_page.h
index 4554e5e41a3e9c547d54c42652a3abc9fa6d16ff..7c5f0a48599736524e3321bd95cc527b7b771509 100644
--- a/components/security_interstitials/content/security_interstitial_page.h
+++ b/components/security_interstitials/content/security_interstitial_page.h
@@ -27,9 +27,11 @@ class SecurityInterstitialControllerClient;
class SecurityInterstitialPage : public content::InterstitialPageDelegate {
public:
+ // |request_url| refers to the URL that triggers the interstitial page. it
+ // can be a main frame URL or subresource URL.
meacer 2017/01/11 01:33:31 The comment might not be accurate for non-SafeBrow
Jialiu Lin 2017/01/11 02:53:16 much better. Thanks! (I think you meant "For SSL i
SecurityInterstitialPage(
content::WebContents* web_contents,
- const GURL& url,
+ const GURL& request_url,
std::unique_ptr<SecurityInterstitialControllerClient> controller);
~SecurityInterstitialPage() override;

Powered by Google App Engine
This is Rietveld 408576698