Componentize SafeBrowsingBlockingPage for WebView use

components/security_interstitials/content/security_interstitial_page.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_SECURITY_INTERSTITIALS_CONTENT_SECURITY_INTERSTITIAL_PAGE_H_
 #define COMPONENTS_SECURITY_INTERSTITIALS_CONTENT_SECURITY_INTERSTITIAL_PAGE_H_
 
 #include <memory>
 
 #include "base/macros.h"
 #include "base/strings/string16.h"
 #include "content/public/browser/interstitial_page_delegate.h"
 #include "url/gurl.h"
 
 namespace base {
 class DictionaryValue;
 }
 
 namespace content {
 class InterstitialPage;
 class WebContents;
 }
 
 namespace security_interstitials {
 class MetricsHelper;
 class SecurityInterstitialControllerClient;
 
 class SecurityInterstitialPage : public content::InterstitialPageDelegate {
  public:
+  // |request_url| refers to the URL that triggers the interstitial page. it
+  // can be a main frame URL or subresource URL.

[meacer, 2017/01/11 01:33:31]

The comment might not be accurate for non-SafeBrowsing interstitials. For
example, there is no subresource URL for SSL interstitials. Not sure how to make
the comment apply for both types of interstitials. How about:

"|request_url| is the URL which triggered the interstitial page. For
SafeBrowsing interstitials, it can be a main frame or a subresource URL. For SSL
interstitials, it's always the subresource URL"

[Jialiu Lin, 2017/01/11 02:53:16]

much better. Thanks!
(I think you meant "For SSL interstitials, it's always the main frame url.")

   SecurityInterstitialPage(
       content::WebContents* web_contents,
-      const GURL& url,
+      const GURL& request_url,
       std::unique_ptr<SecurityInterstitialControllerClient> controller);
   ~SecurityInterstitialPage() override;
 
   // Creates an interstitial and shows it.
   virtual void Show();
 
   // Prevents creating the actual interstitial view for testing.
   void DontCreateViewForTesting();
 
  protected:
@@ skipping 40 matching lines @@
   std::unique_ptr<SecurityInterstitialControllerClient> controller_;
 
   std::unique_ptr<MetricsHelper> metrics_helper_;
 
   DISALLOW_COPY_AND_ASSIGN(SecurityInterstitialPage);
 };
 
 }  // security_interstitials
 
 #endif  // COMPONENTS_SECURITY_INTERSTITIALS_CONTENT_SECURITY_INTERSTITIAL_PAGE_H_