Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Unified Diff: components/security_interstitials/core/metrics_helper.h

Issue 2623733002: Componentize SafeBrowsingBlockingPage for WebView use (Closed)
Patch Set: address final comments Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/security_interstitials/core/metrics_helper.h
diff --git a/components/security_interstitials/core/metrics_helper.h b/components/security_interstitials/core/metrics_helper.h
index fb412d0514dfcaa956109b355152bec53778a0f9..af8602eb1491f34a1b196fc20c42e08971bb3887 100644
--- a/components/security_interstitials/core/metrics_helper.h
+++ b/components/security_interstitials/core/metrics_helper.h
@@ -92,9 +92,9 @@ class MetricsHelper {
protected:
// Subclasses should implement any embedder-specific recording logic in these
// methods. They'll be invoked from the matching Record methods.
- virtual void RecordExtraUserDecisionMetrics(Decision decision) = 0;
- virtual void RecordExtraUserInteractionMetrics(Interaction interaction) = 0;
- virtual void RecordExtraShutdownMetrics() = 0;
+ virtual void RecordExtraUserDecisionMetrics(Decision decision);
+ virtual void RecordExtraUserInteractionMetrics(Interaction interaction);
+ virtual void RecordExtraShutdownMetrics();
private:
// Used to query the HistoryService to see if the URL is in history. It will

Powered by Google App Engine
This is Rietveld 408576698