Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Unified Diff: components/security_interstitials/content/security_interstitial_page.h

Issue 2623733002: Componentize SafeBrowsingBlockingPage for WebView use (Closed)
Patch Set: address final comments Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/security_interstitials/content/security_interstitial_page.h
diff --git a/components/security_interstitials/content/security_interstitial_page.h b/components/security_interstitials/content/security_interstitial_page.h
index 4554e5e41a3e9c547d54c42652a3abc9fa6d16ff..15d28295b24dc019b5895df1c42ba62cbbf375d6 100644
--- a/components/security_interstitials/content/security_interstitial_page.h
+++ b/components/security_interstitials/content/security_interstitial_page.h
@@ -27,9 +27,12 @@ class SecurityInterstitialControllerClient;
class SecurityInterstitialPage : public content::InterstitialPageDelegate {
public:
+ // |request_url| is the URL which triggered the interstitial page. For
+ // SafeBrowsing interstitials, it can be a main frame or a subresource URL.
+ // For SSL interstitials, it's always the main frame URL.
SecurityInterstitialPage(
content::WebContents* web_contents,
- const GURL& url,
+ const GURL& request_url,
std::unique_ptr<SecurityInterstitialControllerClient> controller);
~SecurityInterstitialPage() override;
« no previous file with comments | « components/safe_browsing/base_ui_manager.cc ('k') | components/security_interstitials/core/metrics_helper.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698