Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(924)

Unified Diff: chrome/browser/safe_browsing/threat_details.h

Issue 2623733002: Componentize SafeBrowsingBlockingPage for WebView use (Closed)
Patch Set: address final comments Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_browsing/threat_details.h
diff --git a/chrome/browser/safe_browsing/threat_details.h b/chrome/browser/safe_browsing/threat_details.h
index 4e3275c73980dbaf027f5eb0dd5de9798fe708e0..701782ad7455ce45a1d246d4e19b550d5f8f13bc 100644
--- a/chrome/browser/safe_browsing/threat_details.h
+++ b/chrome/browser/safe_browsing/threat_details.h
@@ -53,7 +53,7 @@ class ThreatDetails : public base::RefCountedThreadSafe<
typedef security_interstitials::UnsafeResource UnsafeResource;
// Constructs a new ThreatDetails instance, using the factory.
- static ThreatDetails* NewThreatDetails(SafeBrowsingUIManager* ui_manager,
+ static ThreatDetails* NewThreatDetails(BaseUIManager* ui_manager,
content::WebContents* web_contents,
const UnsafeResource& resource);
@@ -83,7 +83,7 @@ class ThreatDetails : public base::RefCountedThreadSafe<
friend class ThreatDetailsFactoryImpl;
friend class TestThreatDetailsFactory;
- ThreatDetails(SafeBrowsingUIManager* ui_manager,
+ ThreatDetails(BaseUIManager* ui_manager,
content::WebContents* web_contents,
const UnsafeResource& resource);
@@ -132,7 +132,7 @@ class ThreatDetails : public base::RefCountedThreadSafe<
void AddRedirectUrlList(const std::vector<GURL>& urls);
- scoped_refptr<SafeBrowsingUIManager> ui_manager_;
+ scoped_refptr<BaseUIManager> ui_manager_;
const UnsafeResource resource_;
@@ -176,7 +176,7 @@ class ThreatDetailsFactory {
virtual ~ThreatDetailsFactory() {}
virtual ThreatDetails* CreateThreatDetails(
- SafeBrowsingUIManager* ui_manager,
+ BaseUIManager* ui_manager,
content::WebContents* web_contents,
const SafeBrowsingUIManager::UnsafeResource& unsafe_resource) = 0;
};
« no previous file with comments | « chrome/browser/safe_browsing/safe_browsing_blocking_page_unittest.cc ('k') | chrome/browser/safe_browsing/threat_details.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698